From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2389 invoked by alias); 29 May 2005 19:05:56 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2379 invoked by uid 22791); 29 May 2005 19:05:52 -0000 Received: from c-66-30-17-189.hsd1.ma.comcast.net (HELO cgf.cx) (66.30.17.189) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 29 May 2005 19:05:52 +0000 Received: by cgf.cx (Postfix, from userid 201) id 9B18513CA7E; Sun, 29 May 2005 15:05:50 -0400 (EDT) Date: Sun, 29 May 2005 20:16:00 -0000 From: Christopher Faylor To: gdb-patches@sourceware.org Subject: Re: RFA: Use lrealpath instead of gdb_realpath Message-ID: <20050529190550.GF11936@trixie.casa.cgf.cx> Mail-Followup-To: gdb-patches@sourceware.org References: <20050528234233.GA3440@nevyn.them.org> <20050529142112.GB23858@nevyn.them.org> <20050529182726.GA28225@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050529182726.GA28225@nevyn.them.org> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00628.txt.bz2 On Sun, May 29, 2005 at 02:27:26PM -0400, Daniel Jacobowitz wrote: >On Sun, May 29, 2005 at 09:09:25PM +0300, Eli Zaretskii wrote: >> Disagree with what part? that backslashes might cause trouble or that >> D:\foo\bar/baz.c is ugly? > >The former part. Sure, the latter is ugly; that's a cosmetic bug in >whatever does the concatenation, as far as I'm concerned. Or you can >pass the result back to lrealpath again and get a properly formatted >filename for the system. Not a bad idea to do that anyway. Or >to xfullpath, which might need some updated logic to support this. > >> > It is not worth my time to continue arguing about filename handling; >> > consider the patch withdrawn indefinitely. >> >> My suggestion is to fix lrealpath so that it (a) converts all >> backslashes to forward slashes, (b) does NOT downcase the result, and >> (c) returns its argument unaltered if the absolute file name does not >> point to an existing file. When modified like that, I think lrealpath >> will work the same on all platforms; as for strdup vs xstrdup part, we >> will need to change the code in GDB to test for a NULL return value. >> >> If this alternative is acceptable to other maintainers, I can >> volunteer to produce a patch along these lines. > >If you want to do the work, I invite you to talk to the Windows >maintainers about it; which would mean Chris and Danny Smith, who I do >not believe reads this list. I doubt they'd be interested in (a), >since Chris obviously disagrees with you about backslashes. But you >might be able to reach agreements on (b) and (c). I wouldn't care about (a) or (b) but I'm not sure that c would meet the criteria of whatever else is using lrealpath. Personally, I prefer seeing lower case filenames always but I wouldn't that's not a deal breaker. cgf