From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17411 invoked by alias); 29 May 2005 18:22:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17403 invoked by uid 22791); 29 May 2005 18:22:44 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 29 May 2005 18:22:44 +0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DcSQs-0007V4-Kq; Sun, 29 May 2005 14:22:42 -0400 Date: Sun, 29 May 2005 19:05:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: mi tty commands Message-ID: <20050529182241.GA28286@nevyn.them.org> Mail-Followup-To: Eli Zaretskii , gdb-patches@sources.redhat.com References: <20050225211911.GA21363@white> <20050225212201.GA3592@nevyn.them.org> <20050228162003.GA27783@white> <20050302025219.GA29948@white> <20050311022644.GA15563@white> <20050522210040.GB9231@white> <20050528230855.GE22435@nevyn.them.org> <20050529142633.GE23858@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00626.txt.bz2 On Sun, May 29, 2005 at 08:48:23PM +0300, Eli Zaretskii wrote: > > > * nto-procfs.c (procfs_create_inferior) > > > * win32-nat.c (child_create_inferior): Use get_inferior_io_terminal. > > > > > > Note how I used the explicit name of the function used, instead of > > > just "accessor function". > > > > Did you mean: > > * nto-procfs.c (procfs_create_inferior): Use > > get_inferior_io_terminal. > > * win32-nat.c (child_create_inferior): Likewise. > > > > ? > > No, I meant what I wrote. > > > I thought it was incorrect to have no colon and log message > > corresponding to a bullet. > > AFAIK, it _is_ correct. I've never seen this style used before, in GDB or elsewhere, nor can I find support for this in standards.texi, which only mentions the abbreviated form for lists of functions. Which doesn't mean you're wrong, of course. FYI, a little sed program to see: sed -n '/)$/ {h; n; /^\t\*/ { H; x; p; a\\ } }' ChangeLog* -- Daniel Jacobowitz CodeSourcery, LLC