From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 553 invoked by alias); 29 May 2005 14:26:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 544 invoked by uid 22791); 29 May 2005 14:26:34 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 29 May 2005 14:26:34 +0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DcOkL-0006KK-4z; Sun, 29 May 2005 10:26:33 -0400 Date: Sun, 29 May 2005 16:22:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: mi tty commands Message-ID: <20050529142633.GE23858@nevyn.them.org> Mail-Followup-To: Eli Zaretskii , gdb-patches@sources.redhat.com References: <20050224203535.GA19967@white> <01c51b79$Blat.v2.4$4089e9a0@zahav.net.il> <20050225211911.GA21363@white> <20050225212201.GA3592@nevyn.them.org> <20050228162003.GA27783@white> <20050302025219.GA29948@white> <20050311022644.GA15563@white> <20050522210040.GB9231@white> <20050528230855.GE22435@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00619.txt.bz2 On Sun, May 29, 2005 at 09:55:23AM +0300, Eli Zaretskii wrote: > > +Show terminal for future runs of program being debugged. > > I think the ``future'' part should be removed from this sentence: what > this command outputs is the terminal used _now_ as well as in the > future. That's not strictly true. It is the terminal that will be used the next time we start the program; we don't know at this point whether it's currently in use or whether the user has changed it since we last started the program. We don't have any way to change it in mid-flight. > * nto-procfs.c (procfs_create_inferior) > * win32-nat.c (child_create_inferior): Use get_inferior_io_terminal. > > Note how I used the explicit name of the function used, instead of > just "accessor function". Did you mean: * nto-procfs.c (procfs_create_inferior): Use get_inferior_io_terminal. * win32-nat.c (child_create_inferior): Likewise. ? I thought it was incorrect to have no colon and log message corresponding to a bullet. -- Daniel Jacobowitz CodeSourcery, LLC