From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31387 invoked by alias); 29 May 2005 02:57:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31346 invoked by uid 22791); 29 May 2005 02:57:45 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 29 May 2005 02:57:45 +0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DcDzj-0003ln-K2 for gdb-patches@sources.redhat.com; Sat, 28 May 2005 22:57:43 -0400 Date: Sun, 29 May 2005 03:11:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [mi] organize possible exec async mi oc command reasons Message-ID: <20050529025743.GB14380@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20050324154602.GA10558@white> <20050324160653.GB29185@nevyn.them.org> <20050324212036.GB10808@white> <20050430193220.GG7009@nevyn.them.org> <20050518040011.GD20928@white> <20050528185302.GG26806@nevyn.them.org> <20050529025349.GA9122@white> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050529025349.GA9122@white> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00605.txt.bz2 On Sat, May 28, 2005 at 10:53:49PM -0400, Bob Rossi wrote: > The patch below should contain all of the changes. Thank you again for > all your help. The more I do this, the more reliable my patches should > become. At least as the GNU coding standard is concerned. > > RCS file: /cvs/src/src/gdb/ChangeLog,v > + * Makefile.in (SUBDIR_MI_OBS, SUBDIR_MI_SRCS): Add mi-common. > + (gdb/mi/ headers): Add mi_common_h. > + (breakpoint.o, infrun.o): Add dependencies mi_common_h. > + * breakpoint.c (include): Add include 'mi/mi-common.h'. > + (print_it_typical): Use async_reason_lookup. > + (watchpoint_check): Ditto. > + * infrun.c (include): Add include 'mi/mi-common.h'. > + (print_stop_reason): Use async_reason_lookup. > + * mi/mi-common.h: New file. > + * mi/mi-common.c: Ditto. > > RCS file: /cvs/src/src/gdb/doc/ChangeLog,v > + * gdb.texinfo (GDB/MI Out-of-band Records): Add bullet enumerating > + the possible reasons why an exec async record would be returned to FE. These bits all look fine, but the new files are missing. I really recommend using "cvs add" in your working trees, or cvsdo add (from the cvsutils package), so that cvs diff -N can include new files. My $HOME/.cvsrc has this: cvs -q rdiff -u diff -upN co -P update -P log -N Some of those options you probably don't want, they're specific to the way I work - but the line for diff is very, very useful because it means I rarely forget about new files. -- Daniel Jacobowitz CodeSourcery, LLC