From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17447 invoked by alias); 28 May 2005 23:49:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17330 invoked by uid 22791); 28 May 2005 23:49:07 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sat, 28 May 2005 23:49:07 +0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DcB3B-0002vQ-Ed; Sat, 28 May 2005 19:49:05 -0400 Date: Sun, 29 May 2005 00:09:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC/RFA] Set current language when dumping symtab Message-ID: <20050528234905.GF22435@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20050504001955.GE2439@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050504001955.GE2439@adacore.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00596.txt.bz2 On Tue, May 03, 2005 at 05:19:55PM -0700, Joel Brobecker wrote: > Hello, > > One of our users tried to use the "maint print symbols syms" command > to dump all the symbols in a text format, and that caused a crash on > x86-windows. The reason for the crash is that dump_symtab() indirectly > uses the current language vector to analyze the symbols and then do > the printing. The symtab language may be different from the current > language, so the current language needs to be temporarily adjusted > during the printing. This is what the attached patch does. > > 2005-05-02 Joel Brobecker > > * symmisc.c (dump_symtab_1): Renamed from dump_symtab. > (dump_symtab): New function. > * Makefile.in (symmisc.o): Add dependency on ui-out.h. What's the new dependency on ui-out.h for? I didn't see anything obvious in the patch. Also, what crashes? i.e. why specifically is it harmful to have the wrong language set? Also, I am not convinced that the new TRY_CATCH is necessary. The only bit likely to throw is print_symbol, which is already wrapped in catch_errors. -- Daniel Jacobowitz CodeSourcery, LLC