From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/alpha] Use correct register for FP branches in alpha_next_pc()
Date: Sat, 28 May 2005 18:54:00 -0000 [thread overview]
Message-ID: <20050528183950.GF26806@nevyn.them.org> (raw)
In-Reply-To: <20050526063735.GL1530@adacore.com>
On Thu, May 26, 2005 at 04:37:35PM +1000, Joel Brobecker wrote:
> Blush... Obvious mistake ...
>
> I looked at the 18 failures I currently have when running the following
> testcase (not yet approved):
>
> http://sources.redhat.com/ml/gdb-patches/2005-05/msg00546.html
>
> It turns out it was an obvious confusion between the register number
> embedded in the instruction, and hte register number as GDB knows it.
> Say for instance we have a conditional branch instruction on f16, right
> now we read register number 16, which is register a0, not f16! The fix
> I just committed seemed to be improving things, but only by chance :-/.
> With the attached patch, all tests now PASS.
>
> 2005-05-26 Joel Brobecker <brobecker@adacore.com>
>
> * alpha-tdep.c (alpha_next_pc): Use correct register number
> for floating-point branch instructions.
>
> Tested on alpha-tru64 5.1a. No regression, fixes all 18 failures
> observed in alpha-step.exp.
>
> OK to apply?
This is OK.
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-05-28 18:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-26 15:08 Joel Brobecker
2005-05-28 18:54 ` Daniel Jacobowitz [this message]
2005-05-29 2:11 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050528183950.GF26806@nevyn.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox