From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1023 invoked by alias); 28 May 2005 18:28:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 820 invoked by uid 22791); 28 May 2005 18:28:30 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sat, 28 May 2005 18:28:30 +0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1Dc62s-0004y8-31 for gdb-patches@sourceware.org; Sat, 28 May 2005 14:28:26 -0400 Date: Sat, 28 May 2005 18:40:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: [commit] Fix "show prompt" Message-ID: <20050528182825.GD26806@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00584.txt.bz2 One of the gcc4 warnings patches incorrectly converted the var_string case; it's a char **, not a char *. Committed as obvious, fixes two testcases on i686-pc-linux-gnu. -- Daniel Jacobowitz CodeSourcery, LLC 2005-05-28 Daniel Jacobowitz * cli/cli-setshow.c (do_setshow_command): Partially revert previous change. Cast to "char **" for var_string. Index: cli/cli-setshow.c =================================================================== RCS file: /cvs/src/src/gdb/cli/cli-setshow.c,v retrieving revision 1.25 diff -u -p -r1.25 cli-setshow.c --- cli/cli-setshow.c 26 May 2005 20:49:03 -0000 1.25 +++ cli/cli-setshow.c 28 May 2005 18:16:21 -0000 @@ -301,8 +301,8 @@ do_setshow_command (char *arg, int from_ switch (c->var_type) { case var_string: - if (((char *)c->var)[0] != '\0') - fputstr_filtered ((char *)c->var, '"', stb->stream); + if (*(char **) c->var) + fputstr_filtered (*(char **) c->var, '"', stb->stream); break; case var_string_noescape: case var_optional_filename: