From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32379 invoked by alias); 28 May 2005 14:22:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32362 invoked by uid 22791); 28 May 2005 14:22:28 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sat, 28 May 2005 14:22:28 +0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1Dc2Cp-0001Zp-1W; Sat, 28 May 2005 10:22:27 -0400 Date: Sat, 28 May 2005 16:50:00 -0000 From: Daniel Jacobowitz To: Hans-Peter Nilsson Cc: gdb-patches@sourceware.org Subject: Re: Committed, MAINTAINERS, sim/cris: Fix make -j race and mark cris-elf as non-broken, cp-name-parser.y Message-ID: <20050528142226.GA5901@nevyn.them.org> Mail-Followup-To: Hans-Peter Nilsson , gdb-patches@sourceware.org References: <200505280858.j4S8wVFA015373@ignucius.se.axis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200505280858.j4S8wVFA015373@ignucius.se.axis.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00579.txt.bz2 Please don't commit unrelated changes together in the future. On Sat, May 28, 2005 at 10:58:31AM +0200, Hans-Peter Nilsson wrote: > cc1: warnings being treated as errors > cp-name-parser.y: In function 'parse_escape': > cp-name-parser.y:1443: warning: 'target_char' may be used > uninitialized in this function > > in the gdb directory. I looked at that problem and concluded > the patch to cp-name-parser.y as an obvious fix. The warning > came from gcc-4.0.0-2 and looks correct; the c_parse_backslash > is a static function and apparently the code *has* that problem; > it's not a false positive. It takes two looks. Then I ran into: Maybe it takes three? Your patch is incorrect, since it is covering up a real problem. It ought to be "return c". > cc1: warnings being treated as errors > /home/hp/simj/src/gdb/source.c: In function '_initialize_source': > /home/hp/simj/src/gdb/source.c:1649: warning: pointer targets in > passing argument 3 of 'add_setshow_uinteger_cmd' differ in > signedness > > but this time, I give up and just blindly commit what I > have as that was obviously the level of testing that was > done when the change exposing that warning was committed. Hello? Please think for a moment or read the beginning of the gdb_byte discussion. Most of us have not started using GCC 4.0.0 yet, and even Andrew hadn't in February. Earlier versions didn't produce that warning. It's quite well known by now that GDB does not build using GCC 4.0.0 and -Werror. -- Daniel Jacobowitz CodeSourcery, LLC