Re: [RFC] Info registers command produces no output for "standard register names"

Daniel Jacobowitz
2005-05-29T19:28:50Z

On Sun, May 29, 2005 at 08:53:50AM +0300, Eli Zaretskii wrote:
> > Date: Sat, 28 May 2005 14:06:57 -0400
> > From: Daniel Jacobowitz <drow@false.org>
> > Cc: gdb-patches@sources.redhat.com
> >
> > + fprintf_filtered (file, "\t(raw 0x");
> > + len = TYPE_LENGTH (value_type (regval));
> > + buffer = value_contents (regval);
> > + for (j = 0; j < len; j++)
> > + {
> > + int idx;
> > + if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG)
> > + idx = j;
> > + else
> > + idx = len - 1 - j;
> > + fprintf_filtered (file, "%02x", (unsigned char) buffer[idx]);
> > + }
> > + fprintf_filtered (file, ")");
>
> Daniel, this kind of output generation loop is bad for i18n. So how
> about if we produce the entire numerical string in memory, then print
> it all, as a string, in one go, together with its decorations? (Yes,
> I know you just copied the old code, but as long as we are
> changing...)

Good point. In this case I don't think it makes much difference, but
it's definitely a good habit to get into; I'll fix that if the patch
goes in.

--
Daniel Jacobowitz
CodeSourcery, LLC