From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-39646-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 21219 invoked by alias); 26 May 2005 03:11:40 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 21211 invoked by uid 22791); 26 May 2005 03:11:38 -0000
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 26 May 2005 03:11:38 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j4Q3BWDc012913;
	Wed, 25 May 2005 23:11:32 -0400
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j4Q3BVO32300;
	Wed, 25 May 2005 23:11:32 -0400
Received: from ballpeen.sfbay.redhat.com (ballpeen.sfbay.redhat.com [172.16.24.33])
	by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id j4Q3BTa8012386;
	Wed, 25 May 2005 23:11:30 -0400
Received: from ballpeen.sfbay.redhat.com (ballpeen.sfbay.redhat.com [127.0.0.1])
	by ballpeen.sfbay.redhat.com (8.13.1/8.13.1) with ESMTP id j4Q3BSLK009271;
	Wed, 25 May 2005 20:11:28 -0700
Received: (from rth@localhost)
	by ballpeen.sfbay.redhat.com (8.13.1/8.13.1/Submit) id j4Q3BStX009270;
	Wed, 25 May 2005 20:11:28 -0700
Date: Thu, 26 May 2005 03:27:00 -0000
From: Richard Henderson <rth@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@gcc.gnu.org
Subject: Re: [testsuite/alpha] Add test for step over fbne instruction
Message-ID: <20050526031128.GA9264@redhat.com>
References: <20050525064819.GA5406@redhat.com> <20050526023539.GL1525@adacore.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050526023539.GL1525@adacore.com>
User-Agent: Mutt/1.4.1i
X-SW-Source: 2005-05/txt/msg00549.txt.bz2

On Thu, May 26, 2005 at 12:35:39PM +1000, Joel Brobecker wrote:
>      "       cpys $f31,$f31,$f0\n"
>      "       fbgt $f16,$gt_1\n"      /* stop at this instruction.  */
>      "       cpysn $f16,$f16,$f0\n"
>      "$gt_1:\n"
>      "       ret $31,($26),1\n"

Hmm, now that I think about it, one potential problem with this form
is that we're not correctly testing for branch taken.  The scenerio
is that we expect taken, set the bp on the ret, the branch *isn't*
taken, but we fall through to the ret anyway.

We'd do better to write this

       "       fbgt $f16,$gt_1\n"      /* stop at this instruction.  */
       "       cpysn $f16,$f16,$f0\n"
       "       ret $31,($26),1\n"
       "$gt_1:\n"
       "       ret $31,($26),1\n"

so that if we choose wrong, we will in fact lose control.


r~