Re: [mi] organize possible exec async mi oc command reasons

Bob Rossi
2005-05-18T03:18:21Z

On Sat, Apr 30, 2005 at 03:32:20PM -0400, Daniel Jacobowitz wrote:
> On Thu, Mar 24, 2005 at 04:20:36PM -0500, Bob Rossi wrote:
> > > I don't have much comment about the patch; it seems like a plausible
> > > idea. However, please pay attention to the coding and formatting
> > > standards:
> > >
> > > - ChangeLog entries are capitalized and end with periods.
> > > - Function definitions have the function name in the first column.
> > > - Function braces are in the first column.
> > > - There's a space before function argument lists.
> > > - Function argument lists have to be indented normally; an argument
> > > on a new line goes at the same depth as the first argument on the
> > > previous line.
> > > - Comments don't use multiple leading *s.
> > >
> > > and so forth.
> > >
> > > I sometimes consider myself the pedantic guardian of GDB's source code
> > > formatting :-)
> >
> > Very sorry for not getting the formatting correct. I respect the rules,
> > I just have a hard time formatting everything perfectly, I'm sure I can
> > do better!
>
> You're still having a bit of trouble with those pesky spaces before
> function argument lists. You've also got spaces in the first column;
> please don't start lines with eight spaces, make sure you use tabs
> appropriately instead.
>
> For example:
> ui_out_field_string (uiout, "reason",
> async_reason_lookup(EXEC_ASYNC_BREAKPOINT_HIT));
>
> Needs to be:
> ui_out_field_string (uiout, "reason",
> async_reason_lookup (EXEC_ASYNC_BREAKPOINT_HIT));
>
> When you wrap a line between a function and its argument list, it gains
> one level of indentation (i.e. two spaces).
>
> > static const char *async_reason_string_lookup[EXEC_ASYNC_LAST+1] =
> > {
> > "breakpoint-hit",
> > "watchpoint-trigger",
> > "read-watchpoint-trigger",
> > "access-watchpoint-trigger",
> > "function-finished",
> > "location-reached",
> > "watchpoint-scope",
> > "end-stepping-range",
> > "exited-signalled",
> > "exited",
> > "exited-normally",
> > "signal-received",
> > (char*)0
>
> NULL, please.

Hi Daniel, I didn't put NULL simply because I didn't know what header to
include to get the symbol. So, should I include defs.h? Or should I
include stdlib.h directly? What if stdlib.h is not defined?

Thanks,
Bob Rossi