From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15916 invoked by alias); 18 May 2005 03:18:21 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15874 invoked from network); 18 May 2005 03:18:17 -0000 Received: from unknown (HELO lakermmtao12.cox.net) (68.230.240.27) by sourceware.org with SMTP; 18 May 2005 03:18:17 -0000 Received: from white ([68.9.64.121]) by lakermmtao12.cox.net (InterMail vM.6.01.04.00 201-2131-118-20041027) with ESMTP id <20050518031812.EGGN10612.lakermmtao12.cox.net@white> for ; Tue, 17 May 2005 23:18:12 -0400 Received: from bob by white with local (Exim 3.35 #1 (Debian)) id 1DYF4X-0005Tc-00 for ; Tue, 17 May 2005 23:18:13 -0400 Date: Wed, 18 May 2005 03:29:00 -0000 From: Bob Rossi To: gdb-patches@sources.redhat.com Subject: Re: [mi] organize possible exec async mi oc command reasons Message-ID: <20050518031812.GA20928@white> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20050324154602.GA10558@white> <20050324160653.GB29185@nevyn.them.org> <20050324212036.GB10808@white> <20050430193220.GG7009@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050430193220.GG7009@nevyn.them.org> User-Agent: Mutt/1.3.28i X-SW-Source: 2005-05/txt/msg00439.txt.bz2 On Sat, Apr 30, 2005 at 03:32:20PM -0400, Daniel Jacobowitz wrote: > On Thu, Mar 24, 2005 at 04:20:36PM -0500, Bob Rossi wrote: > > > I don't have much comment about the patch; it seems like a plausible > > > idea. However, please pay attention to the coding and formatting > > > standards: > > > > > > - ChangeLog entries are capitalized and end with periods. > > > - Function definitions have the function name in the first column. > > > - Function braces are in the first column. > > > - There's a space before function argument lists. > > > - Function argument lists have to be indented normally; an argument > > > on a new line goes at the same depth as the first argument on the > > > previous line. > > > - Comments don't use multiple leading *s. > > > > > > and so forth. > > > > > > I sometimes consider myself the pedantic guardian of GDB's source code > > > formatting :-) > > > > Very sorry for not getting the formatting correct. I respect the rules, > > I just have a hard time formatting everything perfectly, I'm sure I can > > do better! > > You're still having a bit of trouble with those pesky spaces before > function argument lists. You've also got spaces in the first column; > please don't start lines with eight spaces, make sure you use tabs > appropriately instead. > > For example: > ui_out_field_string (uiout, "reason", > async_reason_lookup(EXEC_ASYNC_BREAKPOINT_HIT)); > > Needs to be: > ui_out_field_string (uiout, "reason", > async_reason_lookup (EXEC_ASYNC_BREAKPOINT_HIT)); > > When you wrap a line between a function and its argument list, it gains > one level of indentation (i.e. two spaces). > > > static const char *async_reason_string_lookup[EXEC_ASYNC_LAST+1] = > > { > > "breakpoint-hit", > > "watchpoint-trigger", > > "read-watchpoint-trigger", > > "access-watchpoint-trigger", > > "function-finished", > > "location-reached", > > "watchpoint-scope", > > "end-stepping-range", > > "exited-signalled", > > "exited", > > "exited-normally", > > "signal-received", > > (char*)0 > > NULL, please. Hi Daniel, I didn't put NULL simply because I didn't know what header to include to get the symbol. So, should I include defs.h? Or should I include stdlib.h directly? What if stdlib.h is not defined? Thanks, Bob Rossi