From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21239 invoked by alias); 18 May 2005 01:55:17 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20251 invoked from network); 18 May 2005 01:54:52 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 18 May 2005 01:54:52 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DYDlq-0002xy-NP; Tue, 17 May 2005 21:54:50 -0400 Date: Wed, 18 May 2005 03:18:00 -0000 From: Daniel Jacobowitz To: Martin Koegler , gdb-patches@sources.redhat.com Cc: Dimitry Andric , Simon Richter Subject: Re: [PATCH] Add support for DESTDIR to the simulator core Message-ID: <20050518015450.GC10888@nevyn.them.org> Mail-Followup-To: Martin Koegler , gdb-patches@sources.redhat.com, Dimitry Andric , Simon Richter References: <20050510204920.GA24799@ahab.auto.tuwien.ac.at> <20050510205336.GA11701@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050510205336.GA11701@nevyn.them.org> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00437.txt.bz2 On Tue, May 10, 2005 at 04:53:36PM -0400, Daniel Jacobowitz wrote: > The other two patches did not modify FLAGS_TO_PASS; is this really > necessary? I don't believe it is. I didn't get an answer to this so I am going to assume that it isn't. None of the three submitted versions of this patch had a correct ChangeLog, so I redid it myself. Thank you all for reporting the problem. -- Daniel Jacobowitz CodeSourcery, LLC 2005-05-17 Daniel Jacobowitz * Make-common.in (install-common, installdirs): Honor $DESTDIR. Index: Make-common.in =================================================================== RCS file: /cvs/src/src/sim/common/Make-common.in,v retrieving revision 1.21 diff -u -p -r1.21 Make-common.in --- Make-common.in 27 Apr 2005 20:38:08 -0000 1.21 +++ Make-common.in 18 May 2005 01:54:13 -0000 @@ -616,14 +616,14 @@ install: install-common $(SIM_EXTRA_INST install-common: installdirs n=`echo run | sed '$(program_transform_name)'`; \ - $(INSTALL_PROGRAM) run$(EXEEXT) $(bindir)/$$n$(EXEEXT) + $(INSTALL_PROGRAM) run$(EXEEXT) $(DESTDIR)$(bindir)/$$n$(EXEEXT) n=`echo libsim.a | sed s/libsim.a/lib$(target_alias)-sim.a/`; \ - $(INSTALL_DATA) libsim.a $(libdir)/$$n ; \ - ( cd $(libdir) ; $(RANLIB) $$n ) + $(INSTALL_DATA) libsim.a $(DESTDIR)$(libdir)/$$n ; \ + ( cd $(DESTDIR)$(libdir) ; $(RANLIB) $$n ) installdirs: - $(SHELL) $(srcdir)/../../mkinstalldirs $(bindir) - $(SHELL) $(srcdir)/../../mkinstalldirs $(libdir) + $(SHELL) $(srcdir)/../../mkinstalldirs $(DESTDIR)$(bindir) + $(SHELL) $(srcdir)/../../mkinstalldirs $(DESTDIR)$(libdir) check: cd ../testsuite && $(MAKE) check RUNTESTFLAGS="$(RUNTESTFLAGS)"