Re: PATCH: Read Dwarf2 info from Pascal

Daniel Jacobowitz
2005-05-18T01:50:03Z

On Thu, May 12, 2005 at 03:26:21PM +0200, Waldek Hebisch wrote:
> The patch below adds Pascal support to `dwarf2read.c':
> - reading Dwarf2 info about sets
> - recognizing the language as Pascal
> - allowing namespace declaration (modules) for Pascal
>
> Without the patch gdb can not be used with new versions of Gnu Pascal
> (at least in default mode): gpc based of gcc-3.x defaults to Dwarf2
> debug info (and gdb stops working once a set is found).
>
> The patch is against gdb-6.3, but applies to cvs version (from May 7):
> I have tested it on Debian Woody and the patch coused no new test failures
> (however, unpatched cvs version had 55 unexpected test failures).
>
> The patch is an updated version of the patch I attached to PR 1477 (BTW,
> is anybody looking at Pascal problems?).
>
> If OK please apply, I have no CVS write access. The patch is small, so
> I hope it can go in without legal problems, but if needed I will
> fill the copyright assignment to FSF.

Pierre's right; the ChangeLog needs to be more detailed (and please use
the NAME[space][space]<email@address> style used in the rest of the
ChangeLog). There's at least one place where you used spaces and the
surrounding code used tabs; you can see this very easily by looking at
the diff, where it won't line up properly. And there are some useless
blank lines and braces in the patch - yes, I realize dwarf2read.c has a
lot of these already, but please don't add more.

The patch itself looks sane but Elena would need to review it.

--
Daniel Jacobowitz
CodeSourcery, LLC