From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11382 invoked by alias); 18 May 2005 01:50:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11106 invoked from network); 18 May 2005 01:49:32 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 18 May 2005 01:49:32 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DYDgg-0002uj-PG; Tue, 17 May 2005 21:49:30 -0400 Date: Wed, 18 May 2005 02:23:00 -0000 From: Daniel Jacobowitz To: Waldek Hebisch Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: Read Dwarf2 info from Pascal Message-ID: <20050518014930.GB10888@nevyn.them.org> Mail-Followup-To: Waldek Hebisch , gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00436.txt.bz2 On Thu, May 12, 2005 at 03:26:21PM +0200, Waldek Hebisch wrote: > The patch below adds Pascal support to `dwarf2read.c': > - reading Dwarf2 info about sets > - recognizing the language as Pascal > - allowing namespace declaration (modules) for Pascal > > Without the patch gdb can not be used with new versions of Gnu Pascal > (at least in default mode): gpc based of gcc-3.x defaults to Dwarf2 > debug info (and gdb stops working once a set is found). > > The patch is against gdb-6.3, but applies to cvs version (from May 7): > I have tested it on Debian Woody and the patch coused no new test failures > (however, unpatched cvs version had 55 unexpected test failures). > > The patch is an updated version of the patch I attached to PR 1477 (BTW, > is anybody looking at Pascal problems?). > > If OK please apply, I have no CVS write access. The patch is small, so > I hope it can go in without legal problems, but if needed I will > fill the copyright assignment to FSF. Pierre's right; the ChangeLog needs to be more detailed (and please use the NAME[space][space] style used in the rest of the ChangeLog). There's at least one place where you used spaces and the surrounding code used tabs; you can see this very easily by looking at the diff, where it won't line up properly. And there are some useless blank lines and braces in the patch - yes, I realize dwarf2read.c has a lot of these already, but please don't add more. The patch itself looks sane but Elena would need to review it. -- Daniel Jacobowitz CodeSourcery, LLC