From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20521 invoked by alias); 18 May 2005 01:25:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20477 invoked from network); 18 May 2005 01:25:22 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 18 May 2005 01:25:22 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DYDJJ-0002eJ-EC; Tue, 17 May 2005 21:25:21 -0400 Date: Wed, 18 May 2005 01:45:00 -0000 From: Daniel Jacobowitz To: Manoj Iyer Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] gdb.server testcases (resend) Message-ID: <20050518012521.GB8672@nevyn.them.org> Mail-Followup-To: Manoj Iyer , gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00433.txt.bz2 On Mon, May 16, 2005 at 12:13:17PM -0500, Manoj Iyer wrote: > > In my previous email I missed the changelog. Here is my complete patch. > Please review and comment. > > 2005-05-16 Manoj Iyer > > * gdb.server/server-run.exp: added testcases. > * gdb.server/server.c: added nested function call to test > backtrace. That's not a changelog; it does not describe what has changed. Please follow the conventions for C code when changing C files in the testsuite; each function needs its own entry, for instance. You've changed the indentation in server.c, away from the GNU style. It's not as important to maintain GNU Coding Standards in the testsuite, but please don't ignore it without a reason. > +# test setting a breakpoint Comments are full sentences, start with capital letters, and end with periods. > gdb_breakpoint main > -gdb_test "continue" "Breakpoint.* main .*" "continue to main" > + > +gdb_test "continue" ".*Continuing\\..*Breakpoint \[0-9\], main.*at .*$srcfile:\[0-9\]+.*" > + > +# test if list command displays source code > +gdb_test "list" ".*main.*\{.*\}" > + > +# set breakpoint at a function and test backtrace command > +gdb_test "break function3" "Breakpoint 2 at.*file .*$srcfile, line \[0-9\]+." > + > +gdb_test "continue" ".*Continuing\\..*Breakpoint \[0-9\]+, function3.*at.*$srcfile:\[0-9\]+.*" You'll need to give names to tests; otherwise this test is going to report "PASS: gdb.server/server-run.exp: continue" multiple times. Manoj, before you revise the patch again, could you explain why you want to add these tests? It is possible to run the entire testsuite using gdbserver if you want to specifically validate gdbserver; the purpose of the gdb.server directory is: 1. To make sure that minimal remote protocol support is not accidentally broken by people working on native debuggers. 2. (Someday) to test gdbserver-specific features, like gdbserver --attach. Do these tests add value to #1? We're already testing that we can reach main; on a native configuration that tests breakpoints, continuing, and single-stepping (for the dynamic linker breakpoints). -- Daniel Jacobowitz CodeSourcery, LLC