From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7584 invoked by alias); 17 May 2005 06:30:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7544 invoked from network); 17 May 2005 06:30:36 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 17 May 2005 06:30:36 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j4H6UaPA007121 for ; Tue, 17 May 2005 02:30:36 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j4H6UZO30818; Tue, 17 May 2005 02:30:35 -0400 Received: from ballpeen.sfbay.redhat.com (ballpeen.sfbay.redhat.com [172.16.24.33]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id j4H6UXa8015751; Tue, 17 May 2005 02:30:33 -0400 Received: from ballpeen.sfbay.redhat.com (ballpeen.sfbay.redhat.com [127.0.0.1]) by ballpeen.sfbay.redhat.com (8.13.1/8.13.1) with ESMTP id j4H6UWqX031896; Mon, 16 May 2005 23:30:32 -0700 Received: (from rth@localhost) by ballpeen.sfbay.redhat.com (8.13.1/8.13.1/Submit) id j4H6UWpS031895; Mon, 16 May 2005 23:30:32 -0700 X-Authentication-Warning: ballpeen.sfbay.redhat.com: rth set sender to rth@redhat.com using -f Date: Tue, 17 May 2005 10:21:00 -0000 From: Richard Henderson To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/alpha] Add handling of FP control insn in software-single step Message-ID: <20050517063032.GB31869@redhat.com> References: <20050517023400.GW1462@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050517023400.GW1462@adacore.com> User-Agent: Mutt/1.4.1i X-SW-Source: 2005-05/txt/msg00414.txt.bz2 On Tue, May 17, 2005 at 12:34:00PM +1000, Joel Brobecker wrote: > +static int > +fp_register_sign_bit (char *buf) > +{ > + return (buf[0] & 0x80); Also, this is a big-endian test. > + regcache_cooked_read (current_regcache, (insn >> 21) & 0x1f, reg); > /* Need to determine if branch is taken; read RA. */ > - rav = (LONGEST) read_register ((insn >> 21) & 0x1f); > + rav = extract_signed_integer (reg, 4); And you're only extracting 4 bytes instead of 8. So, basically, not one part of the patch is correct. r~