Re: [patch] update gdb.base/shreloc.exp to use new shared library infrastructure

Wu Zhou
2005-05-17T14:39:14Z

Quoting Daniel Jacobowitz <drow@false.org>:

> On Tue, May 17, 2005 at 06:20:02AM -0400, Wu Zhou wrote:
> > Hi Daniel,
> >
> > Thanks for pointing out these errors for me. Followed is the re-worked
> > patch.
> >
> > 2005-05-17 Paul Gilliam <pgilliam@us.ibm.com>
> > Wu Zhou <woodzltc@cn.ibm.com>
> >
> > * gdb.base/shreloc.exp: Use gdb_compile_shlib. Add support for
> > IBM's xlc compiler.
> > * gdb.base/shreloc1.c (fn_1): Reference variable static_var_1.
> > * gdb.base/shreloc2.c (fn_2): Reference variable static_var_2.
>
> This is fine to commit; do you have write access?
>
> Make sure to use tabs at the beginning of lines in the ChangeLog, and
> to put two spaces between your name and email address.

No. I don't have write access yet. As you might know, I am very new to
GDB development. Maybe I need some good patches to get the write access.
So maybe someone else need to commit this(I can rewrite the changelog).
I could ask Paul to do this. But if you are willing to do it, that will
be highly appreciated.

BTW. thanks for reminding me of the wording rules. And also for your kind
helps all the way. I learned a lot from working with you on this first
patch, which is also my first experience for contributing code to GNU
projects. With your and others' kind help, I believe I can do much better
next time. Thanks once again.

===============The re-worked changelog=================================
2005-05-17 Paul Gilliam <pgilliam@us.ibm.com>
Wu Zhou <woodzltc@cn.ibm.com>

* gdb.base/shreloc.exp: Use gdb_compile_shlib. Add support for
IBM's xlc compiler.
* gdb.base/shreloc1.c (fn_1): Reference variable static_var_1.
* gdb.base/shreloc2.c (fn_2): Reference variable static_var_2.

Cheers
- Wu Zhou