Re: [RFA] Resurrect v850

Corinna Vinschen
2005-05-18T08:53:36Z

On May 17 21:10, Daniel Jacobowitz wrote:
> On Tue, May 17, 2005 at 04:09:35PM +0200, Corinna Vinschen wrote:
> > Ok, I *think* I have followed all your suggestions and hints throughout
> > the file. The result is attached below.
>
> This is OK with trivial changes, with or without Mark's suggested
> change for the type of $pc. Thanks.
>
> > +/* Info gleaned from scanning a function's prologue. */
> > +struct pifsr /* Info about one saved reg */
> > +{
> > + int offset; /* Offset from sp or fp */
> > + int cur_frameoffset; /* Current frameoffset */
> > + int reg; /* Saved register number */
> > +};
>
> Missed a couple of trailing stops in the comments.
>
> > + /* The value is a structure or union with a single element and that
> > + element is either a single basic type or an array of a single basic
> > + type whoes size is greater than or equal to 4 -> returned in register. */
>
> "whose".

I re-inspected the comments and fixed a few more. I've also changed
v850_register_type according to Mark's suggestion.

Applied.

Thanks to both of you,
Corinna

--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat, Inc.