Re: [rfa] Restore "trust-readonly-section"

[Daniel Jacobowitz <drow@false.org>]

On Thu, May 12, 2005 at 04:14:19PM -0700, Michael Snyder wrote:
> Hmm, tabs fubar -- I'll try again with the patch as an attachment.
> 
> ----- Original Message ----- 
> From: "Michael Snyder" <msnyder@redhat.com>
> To: "GDB Patches" <gdb-patches@sources.redhat.com>
> Sent: Thursday, May 12, 2005 3:55 PM
> Subject: [rfa] Restore "trust-readonly-section"
> 
> 
> >This seems to have succumbed to bit-rot -- there are new target-read 
> >functions
> >in target.c that don't pay any attention to this user-settable mode bit.
> >
> >The purpose of "trust-readonly-sections" is to improve speed on
> >targets where reading memory is expensive (mostly remote).
> >It checks to see if a read is from a read-only section, and if so,
> >reads it from the exec file.  It defaults to "off" for safety, but if
> >users choose to use it, it really speeds up prologue analysis
> >(and therefore stepping).
> >
> >This patch just makes it work again.

It seems odd to add the test both in target_xfer_partial (a dispatcher)
and default_xfer_partial (an implementation).  Are they really both
necessary?

The code might be simpler if you push the trust_readonly check inside
target_read_trusted.  Also, could you name that something involving
memory?

-- 
Daniel Jacobowitz
CodeSourcery, LLC