From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2543 invoked by alias); 12 May 2005 20:51:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2531 invoked from network); 12 May 2005 20:51:04 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 12 May 2005 20:51:04 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DWKe7-0003Wu-Nl; Thu, 12 May 2005 16:51:03 -0400 Date: Thu, 12 May 2005 21:05:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: gcc-patches@gcc.gnu.org, gdb-patches@sources.redhat.com Subject: Re: [RFA] Eliminate warnings about snprintf declaration Message-ID: <20050512205103.GB13519@nevyn.them.org> Mail-Followup-To: Eli Zaretskii , gcc-patches@gcc.gnu.org, gdb-patches@sources.redhat.com References: <01c4c990$Blat.v2.2.2$887ec720@zahav.net.il> <41994B9D.9080809@gnu.org> <01c55702$Blat.v2.4$d4764900@zahav.net.il> <20050512150804.GA1808@nevyn.them.org> <01c55708$Blat.v2.4$cfc9f040@zahav.net.il> <20050512154716.GA3513@nevyn.them.org> <01c5570e$Blat.v2.4$1c533160@zahav.net.il> <20050512162453.GA5180@nevyn.them.org> <01c55732$Blat.v2.4$e9bd3640@zahav.net.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01c55732$Blat.v2.4$e9bd3640@zahav.net.il> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00309.txt.bz2 On Thu, May 12, 2005 at 11:40:00PM +0300, Eli Zaretskii wrote: > > Date: Thu, 12 May 2005 12:24:53 -0400 > > From: Daniel Jacobowitz > > Cc: gcc-patches@gcc.gnu.org, gdb-patches@sources.redhat.com > > > > The principle is that any project which uses libiberty, which wants > > these definitions, must request them. Libiberty's config.h is included > > by libiberty source files, before they include libiberty.h. GDB's > > config.h is included by GDB source fles before they include > > libiberty.h. So, if GDB needs the prototype, it is GDB's > > responsibility to request it. > > So I need to add these functions to gdb/configure.ac _and_ to > libiberty/configure.ac; got it. I will post a revised patch soon. > > Thanks for your patience. Almost - you don't actually need them in libiberty/configure.ac, unless you see warnings about them during the build of libiberty. To make GDB -Werror happy, all you need is gdb/configure.ac and include/libiberty.h. Thank you for taking care of it! -- Daniel Jacobowitz CodeSourcery, LLC