Re: PATCH: Use getche on Win32

Daniel Jacobowitz
2005-05-10T20:31:36Z

On Tue, May 10, 2005 at 11:22:17PM +0300, Eli Zaretskii wrote:
> > Date: Tue, 10 May 2005 13:04:52 -0700
> > From: Mark Mitchell <mark@codesourcery.com>
> > CC: bug-readline@gnu.org, gdb-patches@sources.redhat.com
> >
> > > "DTRT" in this case means raise SIGINT when Ctrl-C is pressed and go
> > > left one character when left-arrow is pressed.
> >
> > I take it, then, that you are asking that I implement that functionality
> > in readline?
>
> Well, since we are talking about Readline for GDB, and given the
> importance of SIGINT in GDB, I'd say at least Ctrl-C should work as
> expected.

That's a whole different problem; there's no way to read characters
that will cause proper SIGINT delivery, since the times when GDB cares
about SIGINT are the times when it is not in readline. I don't know if
that's implementable at all (maybe Chris does?), but it won't be near
here.

Does Windows offer anything like appropriate job / pgrp semantics?
That'd really surprise me.

> Editing keys are less critical, since one can always use
> Ctrl-n, Ctrl-p, etc. (but it would be nice to have arrows, Home, End,
> Delete, and Insert keys as well).
>
> > I don't mind doing so; I was merely trying to make something useful
> > available as soon as possible.
>
> If it's important that the current CVS snapshots are available ASAP
> for MinGW users, even though one cannot interrupt the debuggee with
> Ctrl-C, then I don't mind that you check this into the GDB CVS,
> provided that it will be followed soon by more patches to take care of
> the above issues.

I would prefer not to commit patches now that will require followup
patches to change their behavior later; there's not that much of a rush
AFAIK.

--
Daniel Jacobowitz
CodeSourcery, LLC