Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Mark Mitchell <mark@codesourcery.com>,
	bug-readline@gnu.org, gdb-patches@sources.redhat.com
Subject: Re: PATCH: Use getche on Win32
Date: Tue, 10 May 2005 20:49:00 -0000	[thread overview]
Message-ID: <20050510203127.GA10559@nevyn.them.org> (raw)
In-Reply-To: <01c5559e$Blat.v2.4$1b76ee60@zahav.net.il>

On Tue, May 10, 2005 at 11:22:17PM +0300, Eli Zaretskii wrote:
> > Date: Tue, 10 May 2005 13:04:52 -0700
> > From: Mark Mitchell <mark@codesourcery.com>
> > CC: bug-readline@gnu.org,  gdb-patches@sources.redhat.com
> > 
> > > "DTRT" in this case means raise SIGINT when Ctrl-C is pressed and go
> > > left one character when left-arrow is pressed.
> > 
> > I take it, then, that you are asking that I implement that functionality 
> > in readline?
> 
> Well, since we are talking about Readline for GDB, and given the
> importance of SIGINT in GDB, I'd say at least Ctrl-C should work as
> expected.

That's a whole different problem; there's no way to read characters
that will cause proper SIGINT delivery, since the times when GDB cares
about SIGINT are the times when it is not in readline.  I don't know if
that's implementable at all (maybe Chris does?), but it won't be near
here.

Does Windows offer anything like appropriate job / pgrp semantics?
That'd really surprise me.

>  Editing keys are less critical, since one can always use
> Ctrl-n, Ctrl-p, etc. (but it would be nice to have arrows, Home, End,
> Delete, and Insert keys as well).
> 
> > I don't mind doing so; I was merely trying to make something useful 
> > available as soon as possible.
> 
> If it's important that the current CVS snapshots are available ASAP
> for MinGW users, even though one cannot interrupt the debuggee with
> Ctrl-C, then I don't mind that you check this into the GDB CVS,
> provided that it will be followed soon by more patches to take care of
> the above issues.

I would prefer not to commit patches now that will require followup
patches to change their behavior later; there's not that much of a rush
AFAIK.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


  reply	other threads:[~2005-05-10 20:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-09 20:42 Mark Mitchell
2005-05-10  6:01 ` Eli Zaretskii
2005-05-10 11:45   ` Mark Mitchell
2005-05-10 20:05     ` Eli Zaretskii
2005-05-10 20:26       ` Mark Mitchell
2005-05-10 20:31         ` Eli Zaretskii
2005-05-10 20:49           ` Daniel Jacobowitz [this message]
2005-05-10 21:41             ` Christopher Faylor
2005-05-11  6:55               ` Christopher Faylor
2005-05-11  7:13                 ` Eli Zaretskii
2005-05-11  7:17                   ` Mark Mitchell
2005-05-11  7:21                 ` MinGW build instructions (was: PATCH: Use getche on Win32) Eli Zaretskii
2005-05-11  7:29                   ` MinGW build instructions Mark Mitchell
2005-05-11  7:53                     ` Eli Zaretskii
2005-05-11 18:45                     ` Christopher Faylor
2005-05-11 19:05                       ` Eli Zaretskii
2005-05-11 19:58                         ` Christopher Faylor
2005-05-11 23:16                           ` Eli Zaretskii
2005-05-11  6:56             ` PATCH: Use getche on Win32 Mark Mitchell
2005-05-11 13:42               ` Eli Zaretskii
2005-05-13 11:42                 ` Mark Mitchell
2005-05-13 15:18                   ` Eli Zaretskii
2005-05-11  7:07             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050510203127.GA10559@nevyn.them.org \
    --to=drow@false.org \
    --cc=bug-readline@gnu.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mark@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox