Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Ulrich Weigand <uweigand@de.ibm.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] Fix gdbserver on s390(x)
Date: Tue, 10 May 2005 12:13:00 -0000	[thread overview]
Message-ID: <200505101145.j4ABjSh2023763@53v30g15.boeblingen.de.ibm.com> (raw)

Hello,

this patch adds the missing members to the the_low_target struct
in linux-s390-low.c, getting gdbserver working again on s390(x).

Tested on s390-ibm-linux and s390x-ibm-linux.
OK?

Bye,
Ulrich


ChangeLog:

	* linux-s390-low.c (s390_breakpoint, s390_breakpoint_len): Define.
	(s390_get_pc, s390_set_pc, s390_breakpoint_at): New functions.
	(the_low_target): Add new members.

Index: gdb/gdbserver/linux-s390-low.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/linux-s390-low.c,v
retrieving revision 1.4
diff -c -p -r1.4 linux-s390-low.c
*** gdb/gdbserver/linux-s390-low.c	18 Feb 2004 03:42:51 -0000	1.4
--- gdb/gdbserver/linux-s390-low.c	6 May 2005 18:44:32 -0000
*************** s390_cannot_store_register (int regno)
*** 75,83 ****
--- 75,125 ----
    return 0;
  }
  
+ 
+ static const char s390_breakpoint[] = { 0, 1 };
+ #define s390_breakpoint_len 2
+ 
+ static CORE_ADDR
+ s390_get_pc ()
+ {
+   unsigned long pc;
+   collect_register_by_name ("pswa", &pc);
+ #ifndef __s390x__
+   pc &= 0x7fffffff;
+ #endif
+   return pc;
+ }
+ 
+ static void
+ s390_set_pc (CORE_ADDR newpc)
+ {
+   unsigned long pc = newpc;
+ #ifndef __s390x__
+   pc |= 0x80000000;
+ #endif
+   supply_register_by_name ("pswa", &pc);
+ }
+ 
+ static int
+ s390_breakpoint_at (CORE_ADDR pc)
+ {
+   unsigned char c[s390_breakpoint_len];
+   read_inferior_memory (pc, c, s390_breakpoint_len);
+   return memcmp (c, s390_breakpoint, s390_breakpoint_len) == 0;
+ }
+ 
+ 
  struct linux_target_ops the_low_target = {
    s390_num_regs,
    s390_regmap,
    s390_cannot_fetch_register,
    s390_cannot_store_register,
+   s390_get_pc,
+   s390_set_pc,
+   s390_breakpoint,
+   s390_breakpoint_len,
+   NULL,
+   s390_breakpoint_len,
+   s390_breakpoint_at,
  };
+ 
-- 
  Dr. Ulrich Weigand
  Linux on zSeries Development
  Ulrich.Weigand@de.ibm.com


             reply	other threads:[~2005-05-10 11:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-10 12:13 Ulrich Weigand [this message]
2005-05-10 13:53 ` Daniel Jacobowitz
2005-05-10 16:54   ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200505101145.j4ABjSh2023763@53v30g15.boeblingen.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox