From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-39307-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 2991 invoked by alias); 9 May 2005 17:26:04 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 2886 invoked from network); 9 May 2005 17:25:57 -0000
Received: from unknown (HELO sibelius.xs4all.nl) (82.92.89.47)
  by sourceware.org with SMTP; 9 May 2005 17:25:57 -0000
Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2])
	by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j49HPtJb023320
	for <gdb-patches@sources.redhat.com>; Mon, 9 May 2005 19:25:55 +0200 (CEST)
Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1])
	by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j49HPtFH014106
	for <gdb-patches@sources.redhat.com>; Mon, 9 May 2005 19:25:55 +0200 (CEST)
Received: (from kettenis@localhost)
	by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j49HPtK4022805;
	Mon, 9 May 2005 19:25:55 +0200 (CEST)
Date: Mon, 09 May 2005 19:44:00 -0000
Message-Id: <200505091725.j49HPtK4022805@elgar.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: gdb-patches@sources.redhat.com
Subject: [COMMIT/RFC] Always include <sys/types.h> from defs.h
X-SW-Source: 2005-05/txt/msg00210.txt.bz2

Including <sys/types.h> is a prerequisite to including many of the
other <sys/...> header files on BSD-derived systems.  Since it isn't
the case on Linux, evry now and then the build is broken when someone
developing on Linux adds <sys/whetever.h>.  This patch prevents this
from happening ever again.

Committed as obvious, since this is what bfd/sysdep.h and
opcodes/sysdep.h already do.  Makes GDB build on vax-dec-ultrix4.0
again ;-).

Raises the question whether we should move towards eliminating
<sys/types.h> from all other GDB source files.  What do folks think
about that?

Mark


Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* defs.h: Unconditionally include <sys/types.h>.

Index: defs.h
===================================================================
RCS file: /cvs/src/src/gdb/defs.h,v
retrieving revision 1.184
diff -u -p -r1.184 defs.h
--- defs.h 8 May 2005 14:57:41 -0000 1.184
+++ defs.h 9 May 2005 17:19:26 -0000
@@ -26,14 +26,13 @@
 
 #include "config.h"		/* Generated by configure.  */
 
+#include <sys/types.h>
 #include <stdio.h>
 #include <errno.h>		/* System call error return status.  */
 #include <limits.h>
 
 #ifdef HAVE_STDDEF_H
 #include <stddef.h>
-#else
-#include <sys/types.h>		/* For size_t.  */
 #endif
 
 #ifdef HAVE_UNISTD_H