From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29544 invoked by alias); 5 May 2005 15:25:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29434 invoked from network); 5 May 2005 15:25:43 -0000 Received: from unknown (HELO lakermmtao12.cox.net) (68.230.240.27) by sourceware.org with SMTP; 5 May 2005 15:25:43 -0000 Received: from white ([68.9.64.121]) by lakermmtao12.cox.net (InterMail vM.6.01.04.00 201-2131-118-20041027) with ESMTP id <20050505152538.CCXI10612.lakermmtao12.cox.net@white>; Thu, 5 May 2005 11:25:38 -0400 Received: from bob by white with local (Exim 3.35 #1 (Debian)) id 1DTiEL-0008Bp-00; Thu, 05 May 2005 11:25:37 -0400 Date: Thu, 05 May 2005 15:25:00 -0000 From: Bob Rossi To: Dennis Brueni Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] fullname attribute for GDB/MI stack frames Message-ID: <20050505152537.GA31111@white> Mail-Followup-To: Dennis Brueni , gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i X-SW-Source: 2005-05/txt/msg00161.txt.bz2 On Thu, May 05, 2005 at 11:15:26AM -0400, Dennis Brueni wrote: > On Wed, 4 May 2005 20:05:06 -0400, Bob Rossi wrote: > > > > This may or may not be what you mean. However, if you do > > -file-list-exec-source-files, GDB prints the filename and fullname for > > every file that it knows about. The purpose of this is to let the > front > > end know about each and every file that GDB knows about. As I've > stated > > before, I believe most if not all FE's depend on the fullname to be a > > unique key. > > I think you have just struck on the right way to write the tests > for fullname with respect to stack frames. Forget regex's, we > want the value of the fullname to exactly match the same fullname > attribute pumped out by -file-list-exec-source-files. This would just > take one utility function. The test for -file-list-exec-source-files > could then be the central point for verifying the "correctness" of > fullname. I'm willing to redo my stack/fullname tests if this idea > is amenable to the group. The value of the fullname will always match the output of -file-list-exec-source-files. You use the same function "source_full_path_of" and pass in the same symtab that -file-list-exec-source-files uses. In fact, that function reuse's symtab->fullname if it has already been calculated and is still on the disk. I personally think that at best, Eli's originally regex will need to be used. For instance, I don't believe that GDB should change in order to get the proper regex in this testcase. I believe that we should use a regex that matches the current output of GDB. If it is determined that GDB is broke, it can be fixed in another patch. Thanks, Bob Rossi