From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20053 invoked by alias); 4 May 2005 22:07:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19551 invoked from network); 4 May 2005 22:07:08 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 4 May 2005 22:07:08 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DTS1H-0001Wc-Fy; Wed, 04 May 2005 18:07:03 -0400 Date: Wed, 04 May 2005 22:07:00 -0000 From: Daniel Jacobowitz To: Manoj Iyer Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] new GDB server testcase Message-ID: <20050504220703.GB4822@nevyn.them.org> Mail-Followup-To: Manoj Iyer , gdb-patches@sources.redhat.com References: <20050504144044.GA14120@nevyn.them.org> <20050504184620.GA19639@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00146.txt.bz2 On Wed, May 04, 2005 at 04:57:02PM -0500, Manoj Iyer wrote: > Daniel, > > > > > +gdb_test "step" "function4.*at .*$srcfile:\[0-9\]+.*" > > > + > > > +gdb_test "step 3" ".*${decimal}.*y = x.* y;.*" > > > > That's a lot of wildcards. Can't you put a marker comment on the lines > > you want to reach? > > > > I want to test vanilla step and step with value separately, this is why I > did what I did. Also, I referred some of the existing testcases and > followed the style of doing things there. Anyways here is the patch with > most of the mods. ".*${decimal}.*y = x.* y;.*" is line noise. I would prefer something like: gdb_test "step 3" "/\* marker for second step \*/\[\r\n\]+" A trailing .* is to be avoided when possible; it means that warnings or error messages could appear after the step and still pass. They can already appear before the step, which is an unfortunate problem with the way GDB's tests are written. > > 2005-05-05 Manoj Iyer > > * gdb.server/server-run.exp: Added new testcases > * gdb.server/server.c: Added nested function call for backtrace > testing. > > Common subdirectories: ./new/src/gdb/testsuite/gdb.server/CVS and ./old/src/gdb/testsuite/gdb.server/CVS > diff ./new/src/gdb/testsuite/gdb.server/server-run.exp ./old/src/gdb/testsuite/gdb.server/server-run.exp > 41d40 > < # test setting a breakpoint > 43,65c42 > < Bad diff, please do read diffs before you mail them. -- Daniel Jacobowitz CodeSourcery, LLC