Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] maintenance_print_msymbols: Try harder to match files
Date: Mon, 02 May 2005 20:18:00 -0000	[thread overview]
Message-ID: <20050502201851.GB1204@adacore.com> (raw)
In-Reply-To: <20050502200720.GA9490@nevyn.them.org>

> > I don't remember all the details, I could dig up the relevant messages
> > if necessary. But the comment at the begining of the function seems to
> > confirm that this code is correct to be here:
> > 
> >     /* Return a copy of FILENAME, with its directory prefix canonicalized
> >        by gdb_realpath.  */
> > 
> > Perhaps the function is incorrectly named, though (misleading)...
> > Should we consider finding a more meaningful name?
> 
> I would rather see an example of why the current behavior is correct,
> first.

I think I remember the whole story now. The description of the problem
xfullpath fixes is at:

        http://sources.redhat.com/ml/gdb-patches/2002-03/msg00345.html

All the followup messages were refreshing... Basically, we're trying
in xfullpath to avoid canonicalizing the basename part of the path.
So, if the name doesn't have any directory part in it, then we're
done.

-- 
Joel


      reply	other threads:[~2005-05-02 20:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-24 21:09 Corinna Vinschen
2005-05-01 23:37 ` Daniel Jacobowitz
2005-05-02 19:20   ` Eli Zaretskii
2005-05-02 19:46     ` Eli Zaretskii
2005-05-02 20:05   ` Joel Brobecker
2005-05-02 20:07     ` Daniel Jacobowitz
2005-05-02 20:18       ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050502201851.GB1204@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox