From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6305 invoked by alias); 2 May 2005 20:07:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6031 invoked from network); 2 May 2005 20:07:20 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 2 May 2005 20:07:20 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DShCK-0002TM-4r for ; Mon, 02 May 2005 16:07:20 -0400 Date: Mon, 02 May 2005 20:07:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA] maintenance_print_msymbols: Try harder to match files Message-ID: <20050502200720.GA9490@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20050124210931.GE17455@cygbert.vinschen.de> <20050501233700.GD4311@nevyn.them.org> <20050502200515.GA1204@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050502200515.GA1204@adacore.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00067.txt.bz2 On Mon, May 02, 2005 at 01:05:15PM -0700, Joel Brobecker wrote: > > The xfullpath call doesn't do what you think it does: > > > > /* Extract the basename of filename, and return immediately > > a copy of filename if it does not contain any directory prefix. */ > > if (base_name == filename) > > return xstrdup (filename); > > > > I've got no idea at all why that is there. Joel added this function; > > maybe he can explain. > > I don't remember all the details, I could dig up the relevant messages > if necessary. But the comment at the begining of the function seems to > confirm that this code is correct to be here: > > /* Return a copy of FILENAME, with its directory prefix canonicalized > by gdb_realpath. */ > > Perhaps the function is incorrectly named, though (misleading)... > Should we consider finding a more meaningful name? I would rather see an example of why the current behavior is correct, first. -- Daniel Jacobowitz CodeSourcery, LLC