From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29956 invoked by alias); 2 May 2005 00:54:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29417 invoked from network); 2 May 2005 00:54:17 -0000 Received: from unknown (HELO lakermmtao06.cox.net) (68.230.240.33) by sourceware.org with SMTP; 2 May 2005 00:54:17 -0000 Received: from white ([68.9.64.121]) by lakermmtao06.cox.net (InterMail vM.6.01.04.00 201-2131-118-20041027) with ESMTP id <20050502005415.PNJN749.lakermmtao06.cox.net@white>; Sun, 1 May 2005 20:54:15 -0400 Received: from bob by white with local (Exim 3.35 #1 (Debian)) id 1DSPCR-0005cy-00; Sun, 01 May 2005 20:54:15 -0400 Date: Mon, 02 May 2005 00:54:00 -0000 From: Bob Rossi To: Eli Zaretskii Cc: Dennis Brueni , gdb-patches@sources.redhat.com Subject: Re: [RFC] fullname attribute for GDB/MI stack frames Message-ID: <20050502005415.GA21588@white> Mail-Followup-To: Eli Zaretskii , Dennis Brueni , gdb-patches@sources.redhat.com References: <20050430191755.GF7009@nevyn.them.org> <20050501021945.GA19962@white> <01c54e7a$Blat.v2.4$e31afae0@zahav.net.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01c54e7a$Blat.v2.4$e31afae0@zahav.net.il> User-Agent: Mutt/1.3.28i X-SW-Source: 2005-05/txt/msg00033.txt.bz2 On Sun, May 01, 2005 at 09:22:31PM +0300, Eli Zaretskii wrote: > > Date: Sat, 30 Apr 2005 22:19:45 -0400 > > From: Bob Rossi > > > > On Sat, Apr 30, 2005 at 03:17:55PM -0400, Daniel Jacobowitz wrote: > > > On Fri, Apr 01, 2005 at 02:13:33PM -0500, Dennis Brueni wrote: > > > > > Again, for the fullname regex, I would recommend using the > > > > > same regex used in mi-file.exp. This would be like > > > > > fullname="/.*basics.c" This forces the regex to ensure that > > > > > the path is absolute, which the check you have does not. > > > > > > Will GDB always output absolute paths that start with "/"? What about > > > non-Cygwin Windows for example? DJGPP? > > To answer Daniel's question: no, absolute file names on DOS/Windows > systems do not necessarily begin with a slash. > > > Like Dennis noted, it could be possible that the fullname might not > > start with a "/". I originally posted the patch with the fullname > > starting with a "/", and since then, there hasn't been any complaints. > > If there is a better regex that ensures that the fullname is absolute > > I'd be happy to change the mi-file.exp test to it. > > The proper regexp should be something like > > \([A-z]:\)?[/\\].*basics.c Eli, is this correct? Is a proper fullname in windows \abc? Should the regex move the \\ into the first grouping with the drive letter? \([A-z]:\\\)?/.*basics.c Please let me know. Thanks, Bob Rossi