From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9420 invoked by alias); 1 May 2005 23:17:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9357 invoked from network); 1 May 2005 23:16:59 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 1 May 2005 23:16:59 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DSNgG-00016L-J6; Sun, 01 May 2005 19:16:56 -0400 Date: Sun, 01 May 2005 23:17:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Cc: Michael Snyder Subject: Re: [RFC] mips_abi_update, flush_cached_frames Message-ID: <20050501231655.GA14925@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com, Michael Snyder References: <015a01c53655$98481cb0$8ca66b80@msnyder8600> <20050401010040.GA17642@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050401010040.GA17642@nevyn.them.org> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00027.txt.bz2 On Thu, Mar 31, 2005 at 08:00:40PM -0500, Daniel Jacobowitz wrote: > On Thu, Mar 31, 2005 at 04:56:05PM -0800, Michael Snyder wrote: > > Check me out here -- if you change the abi, it seems to me > > you better make sure you get rid of any cached frames... > > > > 2005-03-31 msnyder > > > > * mips-tdep.c (mips_abi_update): If abi is changed, cached > > frames better be flushed. > > Yes and no - I don't think this is the right place to do it. > My current feeling is that this belongs in > deprecated_current_gdbarch_select_hack. > > [You're definitely right about the problem, though. I ran into this on > ARM last week.] I've committed this more general fix. -- Daniel Jacobowitz CodeSourcery, LLC 2005-05-01 Daniel Jacobowitz * gdbarch.sh (deprecated_current_gdbarch_select_hack): Flush cached frames when changing gdbarch. * gdbarch.c: Regenerated. Index: gdbarch.c =================================================================== RCS file: /cvs/src/src/gdb/gdbarch.c,v retrieving revision 1.323 diff -u -p -r1.323 gdbarch.c --- gdbarch.c 1 May 2005 19:58:52 -0000 1.323 +++ gdbarch.c 1 May 2005 23:13:39 -0000 @@ -4241,6 +4241,7 @@ deprecated_current_gdbarch_select_hack ( current_gdbarch_swap_out_hack (); current_gdbarch_swap_in_hack (new_gdbarch); architecture_changed_event (); + flush_cached_frames (); } extern void _initialize_gdbarch (void); Index: gdbarch.sh =================================================================== RCS file: /cvs/src/src/gdb/gdbarch.sh,v retrieving revision 1.358 diff -u -p -r1.358 gdbarch.sh --- gdbarch.sh 1 May 2005 19:58:53 -0000 1.358 +++ gdbarch.sh 1 May 2005 23:13:40 -0000 @@ -2216,6 +2216,7 @@ deprecated_current_gdbarch_select_hack ( current_gdbarch_swap_out_hack (); current_gdbarch_swap_in_hack (new_gdbarch); architecture_changed_event (); + flush_cached_frames (); } extern void _initialize_gdbarch (void);