From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8250 invoked by alias); 1 May 2005 21:56:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8234 invoked from network); 1 May 2005 21:56:10 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 1 May 2005 21:56:10 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DSMQ4-0003PF-RO; Sun, 01 May 2005 17:56:08 -0400 Date: Sun, 01 May 2005 21:56:00 -0000 From: Daniel Jacobowitz To: Thomas Maier Cc: gdb-patches@sources.redhat.com Subject: Re: gdb 6.3 C++ breakpoint in constructor/destructor patch Message-ID: <20050501215608.GA13059@nevyn.them.org> Mail-Followup-To: Thomas Maier , gdb-patches@sources.redhat.com References: <20050501190532.GB9429@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00024.txt.bz2 On Sun, May 01, 2005 at 10:53:05PM +0200, Thomas Maier wrote: > Ok, hmm, then the code in find_line_symtab() must not return one symtab, > which is used to find one or more references to the lineno, it must return > a list of symtabs with references to this lineno. Means, a similar search > over all symtabs which is already done in find_line_symtab(). > Would that be enough to handle the file:lineno case? > > (If yes it think a new function like find_multi_line_symtab() is the best > way to do it, then in decode_all_digits() fill in the sals with the found > symtabs + linenos) It's a representation problem. I found it much more effective to have decode_line_1 only return one symtab_and_line structure, and then expand them to multiple PCs later, regardless of whether the symtab returned was the only relevant one. Otherwise, things like "list" will get confused. -- Daniel Jacobowitz CodeSourcery, LLC