From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20843 invoked by alias); 1 May 2005 20:41:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20825 invoked from network); 1 May 2005 20:41:24 -0000 Received: from unknown (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org with SMTP; 1 May 2005 20:41:24 -0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j41KfJj1028731; Sun, 1 May 2005 22:41:19 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j41KfJk7023118; Sun, 1 May 2005 22:41:19 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j41KfFAA011729; Sun, 1 May 2005 22:41:15 +0200 (CEST) Date: Sun, 01 May 2005 20:41:00 -0000 Message-Id: <200505012041.j41KfFAA011729@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: cagney@gnu.org CC: eliz@gnu.org, mark.kettenis@xs4all.nl, gdb-patches@sources.redhat.com In-reply-to: <42753958.70109@gnu.org> (message from Andrew Cagney on Sun, 01 May 2005 16:17:28 -0400) Subject: Re: [commit] Use bfd_byte in value.h References: <42710E90.3030300@gnu.org> <200504281919.j3SJJKF1011501@elgar.sibelius.xs4all.nl> <42715EE8.5070704@gnu.org> <01c54c8a$Blat.v2.4$ffbe8140@zahav.net.il> <42753958.70109@gnu.org> X-SW-Source: 2005-05/txt/msg00021.txt.bz2 Date: Sun, 01 May 2005 16:17:28 -0400 From: Andrew Cagney Eli, Last time this came up I recommeded separating out the idea of gdb_byte and proposed more formally. How is this going? In the mean time though (then and now) I'll use bfd_byte as that lets me move this code forward addressing the more immediate problem of not even compiling with -Werror on GCC 4. With that done, i'm pretty sure that we'll find the follow-on task of s/bfd_byte/gdb_byte/ trivial. But why do we need special type at all. ISO C has void * for arbitrary (byte) buffers. That's the type that should have been used for the memory_insert_breakpoint/memory_remove_breakpoint interface changes you just committed. Any implementation of that interface should do the appropriate cast if it needs to do pointer arithmetic, or needs to interpret the bytes as signed or unsigned. If we agree on that, this makes the follow-in task you mention non-trivial. Since you are alreading spending an effort on this, why not spend a small amount of extra effort and fix things properly now? Mark