From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24110 invoked by alias); 30 Apr 2005 19:18:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24018 invoked from network); 30 Apr 2005 19:17:56 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 30 Apr 2005 19:17:56 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DRxTP-0001Y1-C2; Sat, 30 Apr 2005 15:17:55 -0400 Date: Sat, 30 Apr 2005 19:18:00 -0000 From: Daniel Jacobowitz To: Dennis Brueni Cc: gdb-patches@sources.redhat.com, bob@brasko.net Subject: Re: [RFC] fullname attribute for GDB/MI stack frames Message-ID: <20050430191755.GF7009@nevyn.them.org> Mail-Followup-To: Dennis Brueni , gdb-patches@sources.redhat.com, bob@brasko.net References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00454.txt.bz2 On Fri, Apr 01, 2005 at 02:13:33PM -0500, Dennis Brueni wrote: > > Again, for the fullname regex, I would recommend using the > > same regex used in mi-file.exp. This would be like > > fullname="/.*basics.c" This forces the regex to ensure that > > the path is absolute, which the check you have does not. Will GDB always output absolute paths that start with "/"? What about non-Cygwin Windows for example? DJGPP? In any case, if you want to verify that fullname starts with a full path, it can be an independent test. It doesn't need to live in every other MI stack test. > > > > Bob Rossi > > > > As promised, here is an updated patch set with the regex > changes you suggested, plus checking for a little more directory > information with respect to the fullname path, to the extent > that we can be sure the test case still passes in all environments. I don't think adding fullname= to the -i=mi2 output is a good idea; MI2 is supposed to be stable. Bob, what do you think? Anyone else? A couple administrative things about submitting GDB patches: - Please include ChangeLog entries as text, not as diff. They'll never apply correctly when someone else wants to test or commit the patch. - Please use full sentences. This: > + * stack.c (print_frame): In MI mode, > + output fullname attribute with stack frame becomes: * stack.c (print_frame): In MI mode, output the fullname attribute with the stack frame. - Follow the GNU coding standards (you can find a copy on gnu.org) in any new code. For instance, spaces before parentheses in function calls; and braces on new lines rather than at the end of existing lines. You don't need to redo the patch; I'll take care of it once my first questions are resolved. -- Daniel Jacobowitz CodeSourcery, LLC