From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8659 invoked by alias); 30 Apr 2005 18:33:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8646 invoked from network); 30 Apr 2005 18:33:02 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 30 Apr 2005 18:33:02 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DRwlu-0002g9-7S; Sat, 30 Apr 2005 14:33:00 -0400 Date: Sat, 30 Apr 2005 18:33:00 -0000 From: Daniel Jacobowitz To: Wu Zhou Cc: pgilliam@us.ibm.com, gdb-patches@sources.redhat.com Subject: Re: [patch] update gdb.base/shreloc.exp to use new shared library infrastructure Message-ID: <20050430183256.GB7009@nevyn.them.org> Mail-Followup-To: Wu Zhou , pgilliam@us.ibm.com, gdb-patches@sources.redhat.com References: <200504131013.36814.pgilliam@us.ibm.com> <200504191731.06753.pgilliam@us.ibm.com> <20050427155733.GB8399@nevyn.them.org> <200504291617.53756.pgilliam@us.ibm.com> <42734A7E.1030208@cn.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42734A7E.1030208@cn.ibm.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00450.txt.bz2 On Sat, Apr 30, 2005 at 05:06:06PM +0800, Wu Zhou wrote: > Hi, Paul and Daniel > > I made some little modification to the comments on the xlc-specific > options and also added a short text in changelog to explain why they are > necessary. I wish that I could make myself understood. But if there are > any errors or confusion, please feel free to let me know. Thanks. This does not be long in the changelog, only in the comments. The ChangeLog for this patch should look like: 2005-04-29 Paul Gilliam Wu Zhou * gdb.base/shreloc.exp: Use gdb_compile_shlib. Add support for IBM's xlc compiler. If you're going to post patches to this list, please find a mail client which does not mangle line wrapping; the patch as I received it is hard to read and can not be applied. > ! if [test_compiler_info "xlc-*"] { > ! > ! # static variable static_var_1 & static_var_2 are not used > anywhere, IBM's > ! # xlc compiler optimizes them out by default, "-qdbxextra" adds > them back > ! > ! lappend lib_opts "additional_flags=-qdbxextra" > ! > ! # IBM's xlc compiler doesn't add static variables to the symtab by > default, > ! # so there is no static_var_1 & static_var_2 in the output of > "maint print > ! # msymbols ${msymfile}", "-qstatsym" causes them to be added. > ! > ! lappend lib_opts "additional_flags=-qstatsym" > ! > } OK, now I understand why you needed the options. We will need -qstatsym; here's a better description: # IBM's xlc compiler does not add static variables to the ELFe symbol # table by default. We need this option to make the variables show # up in "maint print msymbols". Can we fix the testcase instead of adding -qdbxextra, by making the variable referenced? Other compilers do the same optimization, and some of them don't have a handy option to preserve the variable. -- Daniel Jacobowitz CodeSourcery, LLC