From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10824 invoked by alias); 30 Apr 2005 01:45:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10811 invoked from network); 30 Apr 2005 01:45:32 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 30 Apr 2005 01:45:32 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DRh2x-0004BT-Ue; Fri, 29 Apr 2005 21:45:32 -0400 Date: Sat, 30 Apr 2005 01:45:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] New target am33-linux (mn10300) Message-ID: <20050430014531.GA15951@nevyn.them.org> Mail-Followup-To: Michael Snyder , gdb-patches@sources.redhat.com References: <4272D60B.5050709@sonic.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4272D60B.5050709@sonic.net> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00443.txt.bz2 On Fri, Apr 29, 2005 at 05:49:15PM -0700, Michael Snyder wrote: > Index: mn10300-linux-tdep.c > =================================================================== > RCS file: mn10300-linux-tdep.c > diff -N mn10300-linux-tdep.c > *** /dev/null 1 Jan 1970 00:00:00 -0000 > --- mn10300-linux-tdep.c 30 Apr 2005 00:28:15 -0000 > *************** > *** 0 **** > --- 1,221 ---- > + /* Target-dependent code for the Matsushita MN10300 for GDB, the GNU debugger. > + Copyright 2003 > + Free Software Foundation, Inc. Welcome to 2005 :-) This has indeed been languishing... > + /* Transliterated from ... */ > + #define ELF_NGREG 27 > + #define ELF_NFPREG 32 > + > + typedef unsigned char elf_greg_t[4]; > + typedef elf_greg_t elf_gregset_t[ELF_NGREG]; > + > + typedef unsigned char elf_fpreg_t[4]; > + typedef struct > + { > + elf_fpreg_t fpregs[ELF_NFPREG]; > + unsigned char fpcr[4]; > + } elf_fpregset_t; Past experience tells me that this is a bad idea; please pick names for these types (and the other constants) which won't conflict with types in the system headers. > + /* Use a local version of this function to get the correct types for > + regsets, until multi-arch core support is ready. */ > + > + static void > + fetch_core_registers (char *core_reg_sect, unsigned core_reg_size, > + int which, CORE_ADDR reg_addr) Lots of stray braces in this function. But also... > + void > + _initialize_mn10300_linux_tdep (void) > + { > + deprecated_add_core_fns (®set_core_fns); > + } ... that's a pretty good hint that you should update this. Please see i386_regset_from_core_section instead. -- Daniel Jacobowitz CodeSourcery, LLC