Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Jim Blandy <jimb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: allocate namecopy on heap, not stack
Date: Fri, 29 Apr 2005 23:56:00 -0000	[thread overview]
Message-ID: <20050429235649.GA13136@nevyn.them.org> (raw)
In-Reply-To: <vt2wtqldwm5.fsf@zenia.home>

On Fri, Apr 29, 2005 at 05:52:18PM -0500, Jim Blandy wrote:
> Certainly --- did you see this?
> 
> + 
> + /* A temporary buffer for identifiers, so we can null-terminate them.
> + 
> +    We allocate this with xrealloc.  parse_exp_1 used to allocate with
> +    alloca, using the size of the whole expression as a conservative
> +    estimate of the space needed.  However, macro expansion can
> +    introduce names longer than the original expression; there's no
> +    practical way to know beforehand how large that might be.  */
> + char *namecopy;
> + size_t namecopy_size;

No, I didn't.  Thanks for explaining.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


      reply	other threads:[~2005-04-29 23:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-29 21:38 Jim Blandy
2005-04-29 21:39 ` Daniel Jacobowitz
2005-04-29 22:54   ` Jim Blandy
2005-04-29 23:56     ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050429235649.GA13136@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox