From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22215 invoked by alias); 29 Apr 2005 21:39:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22090 invoked from network); 29 Apr 2005 21:39:23 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 29 Apr 2005 21:39:23 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DRdCk-0002SA-R4; Fri, 29 Apr 2005 17:39:22 -0400 Date: Fri, 29 Apr 2005 21:39:00 -0000 From: Daniel Jacobowitz To: Jim Blandy Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: allocate namecopy on heap, not stack Message-ID: <20050429213922.GA9371@nevyn.them.org> Mail-Followup-To: Jim Blandy , gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00435.txt.bz2 On Fri, Apr 29, 2005 at 04:35:35PM -0500, Jim Blandy wrote: > > Committed as obvious. > > 2005-04-28 Jim Blandy > > * parse.c (namecopy): Change allocation conventions. > (namecopy_size): New variable. > (copy_name): Allocate namecopy using xrealloc, instead of assuming > it has adequate space allocated to it. > (parse_exp_1): Don't try to allocate space for namecopy here. What prompted ths change? Even "obvious" patches deserve an explanation. -- Daniel Jacobowitz CodeSourcery, LLC