Re: [patch] update gdb.base/shreloc.exp to use new shared library infrastructure

Daniel Jacobowitz
2005-04-27T15:58:26Z

On Tue, Apr 19, 2005 at 04:31:06PM -0800, Paul Gilliam wrote:
> On Thursday 14 April 2005 12:23, Daniel Jacobowitz wrote:
> > On Wed, Apr 13, 2005 at 09:13:36AM -0800, Paul Gilliam wrote:
> > > This patch updates gdb.base/shreloc.exp to use the new shared library infrastructure in
> > > lib/gdb.exp. All the stuff that has been cut from shlib-call.exp is now part of 'gdb-compile'
> > > or 'gdb-compile-shlib' (new) in lib/gdb.exp.
> > >
> > > This patch depends on the shared infrastructure patch:
> > > http://sources.redhat.com/ml/gdb-patches/2005-04/msg00096.html
> >
> > Waitasec...
> >
> > > ! set additional_flags "additional_flags=-shared"
> > > !
> > > ! if {([istarget "*pc-cygwin"] || [istarget "*pc-mingw32"]) } {
> > > ! set additional_flags "${additional_flags} -Wl,--image-base,0x04000000"
> > > }
> >
> > The common bits don't have support for cygwin/mingw32 DLLs. So just
> > removing this isn't right.
> >
> > > ! set lib_opts [list debug additional_flags=-qstatsym additional_flags=-qdbxextra]
> >
> > Remind me what this option means?
> >
> >
> Here is the next rev of the patch:
>
> 2005-04-19 Paul Gilliam <pgilliam@us.ibm.com>
>
> * gdb.base/shreloc.exp: Change to use new shared library infrastructure
> and update copyright date.

The changelog doesn't mention the xlc changes; it should. The xlc
changes need comments explaining both what the options do, and (the bit
I haven't seen yet) why they are necessary for this test case. You
still removed the cygwin bits.

--
Daniel Jacobowitz
CodeSourcery, LLC