From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3015 invoked by alias); 29 Apr 2005 21:18:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2920 invoked from network); 29 Apr 2005 21:18:30 -0000 Received: from unknown (HELO e35.co.us.ibm.com) (32.97.110.133) by sourceware.org with SMTP; 29 Apr 2005 21:18:30 -0000 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e35.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j3TLIULg145662 for ; Fri, 29 Apr 2005 17:18:30 -0400 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by westrelay02.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j3TLIUI2313386 for ; Fri, 29 Apr 2005 15:18:30 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id j3TLITiP014943 for ; Fri, 29 Apr 2005 15:18:29 -0600 Received: from dyn9047022123-009047022128.beaverton.ibm.com (dyn9047022123-009047022128.beaverton.ibm.com [9.47.22.128]) by d03av04.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j3TLITbH014925 for ; Fri, 29 Apr 2005 15:18:29 -0600 From: Paul Gilliam Reply-To: pgilliam@us.ibm.com To: gdb-patches@sources.redhat.com Subject: Re: [patch] update gdb.base/gdb1555.exp to use new shared library infrastructure Date: Fri, 29 Apr 2005 21:18:00 -0000 User-Agent: KMail/1.6.2 References: <200504131011.18676.pgilliam@us.ibm.com> <20050427155500.GA8399@nevyn.them.org> <200504281503.27638.pgilliam@us.ibm.com> In-Reply-To: <200504281503.27638.pgilliam@us.ibm.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200504291420.51148.pgilliam@us.ibm.com> X-SW-Source: 2005-04/txt/msg00433.txt.bz2 I must get in a hurry, or something.... Please ignore the extra like in the ChangeLog portion of the patch. I'll get rid of it. On Thursday 28 April 2005 15:03, Paul Gilliam wrote: > On Wednesday 27 April 2005 08:55, Daniel Jacobowitz wrote: > > On Tue, Apr 19, 2005 at 04:31:05PM -0800, Paul Gilliam wrote: > > > On Thursday 14 April 2005 12:20, Daniel Jacobowitz wrote: > > > > On Wed, Apr 13, 2005 at 09:11:18AM -0800, Paul Gilliam wrote: > > > > > This patch updates gdb.base/gdb1555.exp to use the new shared library infrastructure in > > > > > lib/gdb.exp. All the stuff that has been cut from shlib-call.exp is now part of 'gdb-compile' > > > > > or 'gdb-compile-shlib' (new) in lib/gdb.exp. > > > > > > > > > > This patch depends on the shared infrastructure patch: > > > > > http://sources.redhat.com/ml/gdb-patches/2005-04/msg00096.html > > > > > > > > > > -=# Paul #=- > > > > > > > > > > 2005-04-13 Paul Gilliam > > > > > > > > > > * gdb.base/gdb1555.exp: Change to use new shared library infrastructure and update > > > > > copyright date. > > > > > > > > OK. Same comment about the indentation of your '||' operators. Also, > > > > be sure to line wrap the ChangeLog for 80 columns. > > > > > > > > > > > Here is the revised patch: > > > > > > 2005-04-19 Paul Gilliam > > > > > > * gdb.base/gdb1555.exp: Change to use new shared library infrastructure > > > and update copyright date. > > > > Two things: in the future, you don't need to mention updating the > > copyright date in the changelog unless you're doing archeology. > > Researching missing years is a change worth documenting, adding the > > current year should be automatic. Also, the changelog is wrong for > > this patch, since you didn't update the copyright date. You should > > have, though :-) > > > > Don't know how I missed that.... > > Here is the new version, OK to commit? > > =# Paul #=- > ---- > 2005-04-19 Paul Gilliam > > * gdb.base/gdb1555.exp: Change to use new shared library infrastructure. > and update copyright date. ^^^^^^^^^^^^^^^^^^^^^ extra line, please ignore. >