From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22127 invoked by alias); 28 Apr 2005 20:42:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22113 invoked from network); 28 Apr 2005 20:42:02 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 28 Apr 2005 20:42:02 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DRFph-0004CM-8s; Thu, 28 Apr 2005 16:42:01 -0400 Date: Thu, 28 Apr 2005 20:42:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: bug-gdb@rich-paul.net, bug-gdb@gnu.org, gdb-patches@sources.redhat.com Subject: Re: [RFA] Fix file name generation in edit_command (was: Ver 6.3 edit command failing) Message-ID: <20050428204201.GA16121@nevyn.them.org> Mail-Followup-To: Eli Zaretskii , bug-gdb@rich-paul.net, bug-gdb@gnu.org, gdb-patches@sources.redhat.com References: <01c54b35$Blat.v2.4$c3f52520@zahav.net.il> <20050427143620.GA1686@nevyn.them.org> <01c54b40$Blat.v2.4$be3bafe0@zahav.net.il> <20050427180410.GA19592@nevyn.them.org> <01c54c32$Blat.v2.4$26bfb1a0@zahav.net.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01c54c32$Blat.v2.4$26bfb1a0@zahav.net.il> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00398.txt.bz2 On Thu, Apr 28, 2005 at 11:36:50PM +0300, Eli Zaretskii wrote: > I ended up committing the attached. Note that it quotes the file > name, to account for possible special characters that would confise > the shell. (I use "..." for quoting because this is more portable to > various shells, including on Windows.) > > Thanks to Daniel and Mark for valuable input. Fine with me. Thanks. The use of "" is not a bulletproof quoting mechanism, but it's better than previously. -- Daniel Jacobowitz CodeSourcery, LLC