From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14081 invoked by alias); 28 Apr 2005 19:21:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14031 invoked from network); 28 Apr 2005 19:21:05 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 28 Apr 2005 19:21:05 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DREZK-0003JQ-Ae; Thu, 28 Apr 2005 15:21:02 -0400 Date: Thu, 28 Apr 2005 19:21:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: cagney@gnu.org, gdb-patches@sources.redhat.com Subject: Re: [commit] Use bfd_byte in value.h Message-ID: <20050428192102.GA12682@nevyn.them.org> Mail-Followup-To: Mark Kettenis , cagney@gnu.org, gdb-patches@sources.redhat.com References: <42710E90.3030300@gnu.org> <200504281919.j3SJJKF1011501@elgar.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200504281919.j3SJJKF1011501@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00394.txt.bz2 On Thu, Apr 28, 2005 at 09:19:20PM +0200, Mark Kettenis wrote: > Date: Thu, 28 Apr 2005 12:25:52 -0400 > From: Andrew Cagney > > This changes value.h to use bfd_byte more consistently. When trying to > fix the signed (string) VS unsigned (buffer) pointer warnings you very > quickly run into these interfaces. > > Hacking on a mac again? > > Anyway, to place my previous comments about this issue in a context, > this really is analogous to strxxx() versus memxxx(). This gives a > clue to what the proper pointer type for these buffers is: `void *'. > I guess GDB's K&R history really shows here. Does converting to `void > *' require more effort than simply replacing things with `bfd_byte *'? Probably, since you can no longer do arithmetic on them. -- Daniel Jacobowitz CodeSourcery, LLC