From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7350 invoked by alias); 28 Apr 2005 03:27:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7260 invoked from network); 28 Apr 2005 03:27:21 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 28 Apr 2005 03:27:21 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DQzgP-0001pv-Bh; Wed, 27 Apr 2005 23:27:21 -0400 Date: Thu, 28 Apr 2005 03:27:00 -0000 From: Daniel Jacobowitz To: Paul Brook Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] Crash on windows hosts Message-ID: <20050428032721.GA6898@nevyn.them.org> Mail-Followup-To: Paul Brook , gdb-patches@sources.redhat.com References: <200504280300.34690.paul@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200504280300.34690.paul@codesourcery.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00381.txt.bz2 On Thu, Apr 28, 2005 at 03:00:34AM +0100, Paul Brook wrote: > serial_fdopen can return NULL on non-unix (ie. windows) hosts. This was > causing a segfault in print_flush. > The attached patch fixes this. > > Ok? > > Paul > > 2005-04-28 Paul Brook > > * exceptions.c (print_flush): Handle NULL gdb_stdout_serial. Hmm, this is probably OK... yeah, should be safe. Give it a day in case anyone who knows more about Windows than I do wants to object. I can't think of any reason to do this; we've already called the stdio flush routines. At worst it'll be cosmetic. -- Daniel Jacobowitz CodeSourcery, LLC