From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7739 invoked by alias); 27 Apr 2005 15:58:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6758 invoked from network); 27 Apr 2005 15:57:35 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 27 Apr 2005 15:57:35 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DQour-0002En-Pv; Wed, 27 Apr 2005 11:57:33 -0400 Date: Wed, 27 Apr 2005 15:58:00 -0000 From: Daniel Jacobowitz To: Paul Gilliam Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] update gdb.base/shreloc.exp to use new shared library infrastructure Message-ID: <20050427155733.GB8399@nevyn.them.org> Mail-Followup-To: Paul Gilliam , gdb-patches@sources.redhat.com References: <200504131013.36814.pgilliam@us.ibm.com> <20050414192309.GA19262@nevyn.them.org> <200504191731.06753.pgilliam@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200504191731.06753.pgilliam@us.ibm.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00365.txt.bz2 On Tue, Apr 19, 2005 at 04:31:06PM -0800, Paul Gilliam wrote: > On Thursday 14 April 2005 12:23, Daniel Jacobowitz wrote: > > On Wed, Apr 13, 2005 at 09:13:36AM -0800, Paul Gilliam wrote: > > > This patch updates gdb.base/shreloc.exp to use the new shared library infrastructure in > > > lib/gdb.exp. All the stuff that has been cut from shlib-call.exp is now part of 'gdb-compile' > > > or 'gdb-compile-shlib' (new) in lib/gdb.exp. > > > > > > This patch depends on the shared infrastructure patch: > > > http://sources.redhat.com/ml/gdb-patches/2005-04/msg00096.html > > > > Waitasec... > > > > > ! set additional_flags "additional_flags=-shared" > > > ! > > > ! if {([istarget "*pc-cygwin"] || [istarget "*pc-mingw32"]) } { > > > ! set additional_flags "${additional_flags} -Wl,--image-base,0x04000000" > > > } > > > > The common bits don't have support for cygwin/mingw32 DLLs. So just > > removing this isn't right. > > > > > ! set lib_opts [list debug additional_flags=-qstatsym additional_flags=-qdbxextra] > > > > Remind me what this option means? > > > > > Here is the next rev of the patch: > > 2005-04-19 Paul Gilliam > > * gdb.base/shreloc.exp: Change to use new shared library infrastructure > and update copyright date. The changelog doesn't mention the xlc changes; it should. The xlc changes need comments explaining both what the options do, and (the bit I haven't seen yet) why they are necessary for this test case. You still removed the cygwin bits. -- Daniel Jacobowitz CodeSourcery, LLC