From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5454 invoked by alias); 27 Apr 2005 15:56:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3412 invoked from network); 27 Apr 2005 15:55:00 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 27 Apr 2005 15:55:00 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DQosO-0002Cz-DL; Wed, 27 Apr 2005 11:55:00 -0400 Date: Wed, 27 Apr 2005 15:56:00 -0000 From: Daniel Jacobowitz To: Paul Gilliam Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] update gdb.base/gdb1555.exp to use new shared library infrastructure Message-ID: <20050427155500.GA8399@nevyn.them.org> Mail-Followup-To: Paul Gilliam , gdb-patches@sources.redhat.com References: <200504131011.18676.pgilliam@us.ibm.com> <20050414192057.GH26377@nevyn.them.org> <200504191731.05658.pgilliam@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200504191731.05658.pgilliam@us.ibm.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00364.txt.bz2 On Tue, Apr 19, 2005 at 04:31:05PM -0800, Paul Gilliam wrote: > On Thursday 14 April 2005 12:20, Daniel Jacobowitz wrote: > > On Wed, Apr 13, 2005 at 09:11:18AM -0800, Paul Gilliam wrote: > > > This patch updates gdb.base/gdb1555.exp to use the new shared library infrastructure in > > > lib/gdb.exp. All the stuff that has been cut from shlib-call.exp is now part of 'gdb-compile' > > > or 'gdb-compile-shlib' (new) in lib/gdb.exp. > > > > > > This patch depends on the shared infrastructure patch: > > > http://sources.redhat.com/ml/gdb-patches/2005-04/msg00096.html > > > > > > -=# Paul #=- > > > > > > 2005-04-13 Paul Gilliam > > > > > > * gdb.base/gdb1555.exp: Change to use new shared library infrastructure and update > > > copyright date. > > > > OK. Same comment about the indentation of your '||' operators. Also, > > be sure to line wrap the ChangeLog for 80 columns. > > > > > Here is the revised patch: > > 2005-04-19 Paul Gilliam > > * gdb.base/gdb1555.exp: Change to use new shared library infrastructure > and update copyright date. Two things: in the future, you don't need to mention updating the copyright date in the changelog unless you're doing archeology. Researching missing years is a change worth documenting, adding the current year should be automatic. Also, the changelog is wrong for this patch, since you didn't update the copyright date. You should have, though :-) -- Daniel Jacobowitz CodeSourcery, LLC