From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31587 invoked by alias); 27 Apr 2005 15:49:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30779 invoked from network); 27 Apr 2005 15:47:58 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 27 Apr 2005 15:47:58 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DQola-00029E-4J; Wed, 27 Apr 2005 11:47:58 -0400 Date: Wed, 27 Apr 2005 15:49:00 -0000 From: Daniel Jacobowitz To: Paul Gilliam Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Fixes testsuit/gdb.base/annota1.exp Message-ID: <20050427154758.GD7765@nevyn.them.org> Mail-Followup-To: Paul Gilliam , gdb-patches@sources.redhat.com References: <200504071025.11668.pgilliam@us.ibm.com> <20050414193642.GB19792@nevyn.them.org> <200504151637.55773.pgilliam@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200504151637.55773.pgilliam@us.ibm.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00359.txt.bz2 On Fri, Apr 15, 2005 at 03:37:55PM -0800, Paul Gilliam wrote: > OK.  this is in partial responce to: >         http://sourceware.org/ml/gdb-patches/2005-04/msg00145.html > > There were two problems with gdb.base/annota1.exp. This patch is only for the second one. > > The problem here is that a bug in backtrace was causing a false nagitive in gdb.base/annota1.exp, > so the feature being tested was OK, but was being failed due to some other bug that caused the > backtrace to not stop at the end. > > NOTE: this also allows for 'doc symbols' like '.printf'. I understand that these are going away > soon, but an extra '\.?' shouldn't hurt anything. > > -=# Paul #=- > > -- > 2005-04-15 Paul Gilliam > > * gdb.base/annota1.exp: Deal with backtrace 'skidding' past > top-of-stack due to a bug unrealted to annotation. I would strongly prefer not to include this one. This isn't a unit testsuite; all GDB tests cover multiple features. Some backtrace bugs only show up in these testcases, because they're so picky. You didn't mention when resubmitting these patches that there were objections to them. That's kind of important. I see that Andrew had the same objection that I do. -- Daniel Jacobowitz CodeSourcery, LLC