From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29744 invoked by alias); 27 Apr 2005 20:02:39 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29629 invoked from network); 27 Apr 2005 20:02:30 -0000 Received: from unknown (HELO e33.co.us.ibm.com) (32.97.110.131) by sourceware.org with SMTP; 27 Apr 2005 20:02:30 -0000 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e33.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j3RK2T4I419418 for ; Wed, 27 Apr 2005 16:02:29 -0400 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay04.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j3RK2TYg226340 for ; Wed, 27 Apr 2005 14:02:29 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id j3RK2Sd6019919 for ; Wed, 27 Apr 2005 14:02:28 -0600 Received: from dyn9047022123-009047022128.beaverton.ibm.com (dyn9047022123-009047022128.beaverton.ibm.com [9.47.22.128]) by d03av01.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j3RK2SAS019897; Wed, 27 Apr 2005 14:02:28 -0600 From: Paul Gilliam Reply-To: pgilliam@us.ibm.com To: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Fixes testsuit/gdb.base/annota1.exp Date: Wed, 27 Apr 2005 20:02:00 -0000 User-Agent: KMail/1.6.2 Cc: Daniel Jacobowitz References: <200504071025.11668.pgilliam@us.ibm.com> <200504151637.55773.pgilliam@us.ibm.com> <20050427154758.GD7765@nevyn.them.org> In-Reply-To: <20050427154758.GD7765@nevyn.them.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Message-Id: <200504271304.14413.pgilliam@us.ibm.com> X-SW-Source: 2005-04/txt/msg00372.txt.bz2 On Wednesday 27 April 2005 08:47, Daniel Jacobowitz wrote: > On Fri, Apr 15, 2005 at 03:37:55PM -0800, Paul Gilliam wrote: > > OK. =A0this is in partial responce to: > > =A0=A0=A0=A0=A0=A0=A0=A0http://sourceware.org/ml/gdb-patches/2005-04/ms= g00145.html > >=20 > > There were two problems with gdb.base/annota1.exp. This patch is only = for the second one. > >=20 > > The problem here is that a bug in backtrace was causing a false nagitiv= e in gdb.base/annota1.exp, > > so the feature being tested was OK, but was being failed due to some ot= her bug that caused the > > backtrace to not stop at the end. > >=20 > > NOTE: this also allows for 'doc symbols' like '.printf'. I understand = that these are going away > > soon, but an extra '\.?' shouldn't hurt anything. > >=20 > > -=3D# Paul #=3D- > >=20 > > -- > > 2005-04-15 Paul Gilliam > >=20 > > * gdb.base/annota1.exp: Deal with backtrace 'skidding' past > > top-of-stack due to a bug unrealted to annotation. >=20 > I would strongly prefer not to include this one. This isn't a unit > testsuite; all GDB tests cover multiple features. Some backtrace bugs > only show up in these testcases, because they're so picky. OK, I understand. I withdraw this patch. >=20 > You didn't mention when resubmitting these patches that there were > objections to them. That's kind of important. I see that Andrew had > the same objection that I do. >=20 Opps, Sorry. I'll be more carefull next time