From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1088 invoked by alias); 26 Apr 2005 13:17:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30287 invoked from network); 26 Apr 2005 13:13:05 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 26 Apr 2005 13:13:05 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DQPs9-0006Sa-4p for ; Tue, 26 Apr 2005 09:13:05 -0400 Date: Tue, 26 Apr 2005 13:17:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: PATCH: Support Windows in event-loop.c Message-ID: <20050426131304.GA24724@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20050421205617.GA13146@nevyn.them.org> <01c54713$Blat.v2.4$5d0b4ea0@zahav.net.il> <20050424221806.GA13942@nevyn.them.org> <426C3270.4050608@codesourcery.com> <20050425042414.GA7322@trixie.casa.cgf.cx> <20050425131611.GA7821@nevyn.them.org> <20050425145023.GD6543@trixie.casa.cgf.cx> <426D05D6.8010903@codesourcery.com> <20050425150422.GA13753@nevyn.them.org> <01c54a12$Blat.v2.4$dba641a0@zahav.net.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01c54a12$Blat.v2.4$dba641a0@zahav.net.il> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00342.txt.bz2 On Tue, Apr 26, 2005 at 06:47:47AM +0300, Eli Zaretskii wrote: > If console handles is the only type that can currently end up in > `select', I don't see why shouldn't we add such an emulation, however > limited. It sounds like, according to everybody who participated in > this thread, any more able emulation is going to be much more complex, > and some of them even involve Mark K.'s dead body. It doesn't seem > right to me to reject the patch because of theoretical deficiencies. > > The code that got committed was virtually the same one suggested > originally, only in slightly different wrapping. FYI, your assumption in the first paragraph is not valid. Both ser-base and MI can add non-console handles to the event loop. I believe both bits are reachable on Windows; Mark just hasn't encountered them yet. We'll deal with it when someone does, I suppose. -- Daniel Jacobowitz CodeSourcery, LLC