From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2178 invoked by alias); 25 Apr 2005 22:29:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2073 invoked from network); 25 Apr 2005 22:29:50 -0000 Received: from unknown (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org with SMTP; 25 Apr 2005 22:29:50 -0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j3PMSDok025799; Tue, 26 Apr 2005 00:28:13 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j3PMSC7j031584; Tue, 26 Apr 2005 00:28:12 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j3PMS8iR028118; Tue, 26 Apr 2005 00:28:08 +0200 (CEST) Date: Mon, 25 Apr 2005 22:29:00 -0000 Message-Id: <200504252228.j3PMS8iR028118@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: mark@codesourcery.com CC: eliz@gnu.org, drow@false.org, me@cgf.cx, gdb-patches@sources.redhat.com In-reply-to: <426D6A6E.1020505@codesourcery.com> (message from Mark Mitchell on Mon, 25 Apr 2005 15:08:46 -0700) Subject: Re: PATCH: Support Windows in event-loop.c References: <20050424221806.GA13942@nevyn.them.org> <426C3270.4050608@codesourcery.com> <20050425042414.GA7322@trixie.casa.cgf.cx> <20050425131611.GA7821@nevyn.them.org> <20050425145023.GD6543@trixie.casa.cgf.cx> <426D05D6.8010903@codesourcery.com> <20050425150422.GA13753@nevyn.them.org> <426D0A11.4060604@codesourcery.com> <20050425152324.GA15521@nevyn.them.org> <426D0C1D.8040600@codesourcery.com> <20050425153549.GA15967@nevyn.them.org> <426D5178.6010502@codesourcery.com> <01c549da$Blat.v2.4$626aed00@zahav.net.il> <426D6518.9050305@codesourcery.com> <200504252158.j3PLwK6B031670@elgar.sibelius.xs4all.nl> <426D6A6E.1020505@codesourcery.com> X-SW-Source: 2005-04/txt/msg00328.txt.bz2 Date: Mon, 25 Apr 2005 15:08:46 -0700 From: Mark Mitchell Mark Kettenis wrote: > Thanks, committed. > > Thanks! That was the last patch, isn't it? If so, can you add some > blurp to NEWS about it? Not *quite* the last patch. There are still readline changes required. By and large, I should think these will be rather less controversial; most of them are just using autoconf macros to avoid using stuff that Windows doesn't have. There is also one patch that basically says "don't use any of that termcap stuff" -- but that's really just a Makefile patch not to link in one file under Windows. I understand that the readline used by GDB contains some GDB-local patches. So, I'm planning to submit my patches to this list, too. I know that normally we'd want to go to the upstream source, but Daniel says that's probably not practical in this case. So, is it OK to submit readline patches here? I'd say, please make an effort to get them into the official readline first. While we have some local readline patches, we should really try to keep the number of them to the minimum. Every local patch makes merging the next version of readline more difficult :-(. Once the stuff is accepted upstream, no one should stop you from importing those changes into GDB's readline. If that really is not practical, try to keep the impact on existing files as minimal as possible. Try to keep things localized, preferably in a seperate source files. That will make life much easier for us in the future. Mark