From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6162 invoked by alias); 18 Apr 2005 22:52:44 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6124 invoked from network); 18 Apr 2005 22:52:41 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 18 Apr 2005 22:52:41 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DNf6d-00072R-JA; Mon, 18 Apr 2005 18:52:39 -0400 Date: Mon, 18 Apr 2005 22:52:00 -0000 From: Daniel Jacobowitz To: Manoj Iyer Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] Use HAVE_LONGLONG instead of __GNUC__ to check for long long support. Message-ID: <20050418225239.GA26935@nevyn.them.org> Mail-Followup-To: Manoj Iyer , gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00212.txt.bz2 On Mon, Apr 18, 2005 at 06:14:47PM -0500, Manoj Iyer wrote: > > Here is a patch to use HAVE_LONGLONG instead of using __GNUC__ for > checking for long long support in compiler. When using a non-gnu compiler > (xlc), natural64, signed64 and unsigned64 are undefined. Please review > patch and approve for commit. > > > 2005-04-18 Manoj Iyer > * configure.ac: Added check for long long. > * config.in: Added define for HAVE_LONGLONG. This is a generated file; run autoheader instead. > * configure: Regenerated. > * words.h: Modified logic to check for HAVE_LONGLONG instead of > __GNUC__, added config.h header file. > > > diff -Naurp src/sim/ppc/config.in new/src/sim/ppc/config.in > --- src/sim/ppc/config.in 2004-09-24 13:39:41.000000000 -0500 > +++ new/src/sim/ppc/config.in 2005-04-18 18:03:37.000000000 -0500 > @@ -298,6 +298,9 @@ > /* Define if you have the header file. */ > #undef HAVE_LOCALE_H > > +/* Define if compiler supports long long type. */ > +#undef HAVE_LONGLONG > + > /* Define if you have the header file. */ > #undef HAVE_MALLOC_H > > diff -Naurp src/sim/ppc/configure.ac new/src/sim/ppc/configure.ac > --- src/sim/ppc/configure.ac 2005-01-12 10:23:21.000000000 -0600 > +++ new/src/sim/ppc/configure.ac 2005-04-18 18:01:58.000000000 -0500 > @@ -681,6 +681,10 @@ if test $ac_cv_struct_statfs = yes; then > [Define if struct statfs is defined in ]) > fi > > +dnl check for long long > +AC_CHECK_TYPE(long long, > + AC_DEFINE(HAVE_LONGLONG, 1, [does compiler supports long long]),) > + [Define if the compiler supports long long.] You don't need the dnl, or the comment above #include "config.h"; don't add comments that just rephrase the following line. -- Daniel Jacobowitz CodeSourcery, LLC